':valid' CSS selector should not be applied to some form controls

• Component: Forms
• Status: RESOLVED FIXED

[Kent Tamura]

<input type=submit> <input type=image> <progress> should not match to :valid pseudo selector.

[Kent Tamura]

Created attachment 56155 [details]
Patch

[Yael]

Thank you for fixing this, Kent.

[Eric Seidel (no email)]

Comment on attachment 56155 [details]
Patch

Why remove the #if?
 #if ENABLE(PROGRESS_TAG)
862861         tagList.add(progressTag.localName().impl());
863  #endif

[Yael]

(In reply to comment #3)
> (From update of attachment 56155 [details])
> Why remove the #if?
>  #if ENABLE(PROGRESS_TAG)
> 862861         tagList.add(progressTag.localName().impl());
> 863  #endif

Since progress is added to the tag names, the HTML parser will not create a progress element for ports that don't support the progress flag, unless it is also added to the tag list. If added to the tag list, the parser will create a "regular" HTML element when the flag is turned off.
Please see ruby and datalist, they are also added to the taglist unconditionally.
However video is not, and in ports that don't enable the video flag, the HTML parser is not creating a video element at all.

[Darin Adler]

Comment on attachment 56155 [details]
Patch

> -    virtual bool isOptionalFormControl() const { return true; }

I don't see any comment or test case about this change. What's the deal with this?

[Kent Tamura]

(In reply to comment #5)
> (From update of attachment 56155 [details])
> > -    virtual bool isOptionalFormControl() const { return true; }
> 
> I don't see any comment or test case about this change. What's the deal with this?

This change should not be included in this patch.  I'll revert it.
It fixes a bug that ':optional' CSS selector should not be applied to <button> and <progress>.

[Kent Tamura]

Created attachment 56295 [details]
Patch (rev.2)

[Kent Tamura]

Landed as r59645.

[WebKit Review Bot]

http://trac.webkit.org/changeset/59645 might have broken GTK Linux 32-bit Release and Qt Linux Release

[Kent Tamura]

(In reply to comment #9)
> http://trac.webkit.org/changeset/59645 might have broken GTK Linux 32-bit Release and Qt Linux Release

I forgot to update another test.  Fixed by r59647.