Summary: | Canvas's toDataURL() should be case insensitive wrt the mimeType argument | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | CLOSED FIXED | ||||||||||
Severity: | Normal | CC: | abarth, commit-queue, eric, hausmann, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Bug Depends on: | 39173 | ||||||||||
Bug Blocks: | 35784 | ||||||||||
Attachments: |
|
Description
Andreas Kling
2010-05-15 00:13:06 PDT
Created attachment 56146 [details]
Proposed patch
Comment on attachment 56146 [details]
Proposed patch
I would suggest linking to the spec in the ChangeLog, at least before landing.
Created attachment 56168 [details]
Patch for landing
Comment on attachment 56168 [details] Patch for landing Clearing flags on attachment: 56168 Committed r59565: <http://trac.webkit.org/changeset/59565> All reviewed patches have been landed. Closing bug. http://trac.webkit.org/changeset/59565 might have broken GTK Linux 32-bit Release This broke gtk. I can't roll it out from my phone, but someone should feel free to. :) it may just need espectations update. ;) Rolling out. Created attachment 56181 [details]
Updated patch with specialized GTK expectations
Apparently GTK doesn't support the image/jpeg mimetype so the test outcome differs slightly.
Comment on attachment 56181 [details] Updated patch with specialized GTK expectations Clearing flags on attachment: 56181 Committed r59581: <http://trac.webkit.org/changeset/59581> All reviewed patches have been landed. Closing bug. Revision r59581 cherry-picked into qtwebkit-2.0 with commit ad27430eb1173d688a5a335edadb1c0d55462732 |