Summary: | Frame has many trivial member functions that should be inlined | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Darin Adler <darin> | ||||
Component: | Page Loading | Assignee: | Darin Adler <darin> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, atwilson, eric, ossy, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Darin Adler
2010-05-14 19:17:33 PDT
Created attachment 56132 [details]
Patch
Hah, member variables named m_kjsStatusBarText and m_kjsDefaultStatusBarText. Comment on attachment 56132 [details] Patch > -void Frame::removeEditingStyleFromElement(Element*) const > -{ > -} > - May as well remove this one from the header, too? r+, after the EWS bots get a chance to churn. Committed r59630: <http://trac.webkit.org/changeset/59630> http://trac.webkit.org/changeset/59630 might have broken Qt Linux Release minimal and Chromium Linux Release Looks like the compile failures are real. But not seen by the EWS. Ugh. :( Working on making the EWS faster this week. EWS built on Qt and was green. It was not too slow, it was wrong! http://trac.webkit.org/changeset/59632 is an attempt to fix the Qt build. Hmmm. I wonder if there are further dependency issues which need work on Qt. Breaks Chromium also. I'm about to land a patch which #includes CSSMutableStyleDeclaration.h in Frame.h - non-ideal, but the alternative is to un-inline more functions which I'm assuming is contrary to what Darin intended. Nobody is responding on IRC on this, so I'm going to make the minimum fix (add #include) to get things to compile for now. (In reply to comment #12) > Breaks Chromium also. > > I'm about to land a patch which #includes CSSMutableStyleDeclaration.h in Frame.h - non-ideal, but the alternative is to un-inline more functions which I'm assuming is contrary to what Darin intended. Nobody is responding on IRC on this, so I'm going to make the minimum fix (add #include) to get things to compile for now. I think it's OK to un-inline some more functions. |