|Product:||WebKit||Reporter:||Kenneth Russell <kbr>|
|Component:||WebGL||Assignee:||Kenneth Russell <kbr>|
|Severity:||Normal||CC:||cmarrin, dglazkov, enne, jamesr, oliver, senorblanco, webkit.review.bot, zmo|
|Version:||528+ (Nightly build)|
Description Kenneth Russell 2010-05-14 17:52:09 PDT
The implementation of the TypedArray specification in WebKit, which originally only contained those types relevant to WebGL, needs Int64Array, Uint64Array and DoubleArray in order to be complete.
Comment 1 Chris Marrin 2010-05-15 08:38:40 PDT
If we add those, we should probably also add BoolArray for completeness
Comment 2 Oliver Hunt 2010-05-15 12:10:01 PDT
why does it need int/uint64? these types cannot be represented in JS at all?
Comment 3 Kenneth Russell 2010-05-15 13:39:08 PDT
(In reply to comment #2) > why does it need int/uint64? these types cannot be represented in JS at all? Oops, I should have checked the spec. You're right, those aren't present. Revised the summary to indicate only DoubleArray needs to be implemented.
Comment 4 Kenneth Russell 2010-06-08 11:49:52 PDT
The TypedArray spec has been modified to call this Float64Array rather than DoubleArray. Updated the summary.
Comment 6 WebKit Review Bot 2011-05-23 22:15:08 PDT
Comment on attachment 94551 [details] Patch Attachment 94551 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8726580 New failing tests: fast/dom/prototype-inheritance.html inspector/profiler/cpu-profiler-profiling.html
Comment 7 WebKit Review Bot 2011-05-23 22:15:13 PDT
Created attachment 94564 [details] Archive of layout-test-results from ec2-cr-linux-03 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-03 Port: Chromium Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 8 Kenneth Russell 2011-05-24 11:33:27 PDT
Created attachment 94649 [details] Patch Updated layout tests affected by new Float64Array property on DOMWindow.
Comment 9 James Robinson 2011-05-24 12:08:37 PDT
Comment on attachment 94649 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=94649&action=review R=me - just some nits on copyright headers > Source/WebCore/bindings/js/JSFloat64ArrayCustom.cpp:2 > + * Copyright (C) 2011 Apple Inc. All rights reserved. think you mean Google > Source/WebCore/bindings/v8/custom/V8Float64ArrayCustom.cpp:28 > + * > + * * Redistributions of source code must retain the above copyright > + * notice, this list of conditions and the following disclaimer. > + * * Redistributions in binary form must reproduce the above > + * copyright notice, this list of conditions and the following disclaimer > + * in the documentation and/or other materials provided with the > + * distribution. > + * * Neither the name of Google Inc. nor the names of its > + * contributors may be used to endorse or promote products derived from > + * this software without specific prior written permission. > + * > + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS > + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT > + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR > + * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT > + * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, > + * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT > + * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, > + * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY > + * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT > + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE > + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. wrong copyright header: should be 2-clause, etc (like the other files in this patch)
Comment 10 Kenneth Russell 2011-05-24 12:49:29 PDT
Comment on attachment 94649 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=94649&action=review >> Source/WebCore/bindings/js/JSFloat64ArrayCustom.cpp:2 >> + * Copyright (C) 2011 Apple Inc. All rights reserved. > > think you mean Google Actually Apple is correct. This code was copied from JSFloat32ArrayCustom.cpp in the same directory. >> Source/WebCore/bindings/v8/custom/V8Float64ArrayCustom.cpp:28 >> + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > > wrong copyright header: should be 2-clause, etc (like the other files in this patch) Will fix upon landing.