Bug 39142

Summary: [chromium] Implement support for composited layers containing only an Image element
Product: WebKit Reporter: Vangelis Kokkevis <vangelis>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dglazkov, fishd, kbr
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Proposed patch
fishd: review+, fishd: commit-queue-
Patch fixed. Added URL to bug in ChangeLog none

Vangelis Kokkevis
Reported 2010-05-14 16:16:39 PDT
Composited Layers that contain only an Image follow a special path that doesn't require allocating additional storage for keeping around the associated bitmap. That path hasn't been implemented in LayerChromium yet.
Attachments
Proposed patch (5.78 KB, patch)
2010-05-14 16:33 PDT, Vangelis Kokkevis 		fishd: review+
fishd: commit-queue-
DetailsFormatted DiffDiff
Patch fixed. Added URL to bug in ChangeLog (5.84 KB, patch)
2010-05-14 16:57 PDT, Vangelis Kokkevis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Vangelis Kokkevis
Comment 1 2010-05-14 16:33:38 PDT
Created attachment 56121 [details] Proposed patch
Darin Fisher (:fishd, Google)
Comment 2 2010-05-14 16:51:23 PDT
Comment on attachment 56121 [details] Proposed patch WebCore/ChangeLog:6 + an Image element. nit: please add a bug reference here. R=me with that fixed.
Vangelis Kokkevis
Comment 3 2010-05-14 16:57:48 PDT
Created attachment 56124 [details] Patch fixed. Added URL to bug in ChangeLog
Vangelis Kokkevis
Comment 4 2010-05-14 16:59:06 PDT
Uploaded the fix but I'm afraid that I might have inadvertently overwrite the r+ bit..
WebKit Commit Bot
Comment 5 2010-05-15 13:03:58 PDT
Comment on attachment 56124 [details] Patch fixed. Added URL to bug in ChangeLog Clearing flags on attachment: 56124 Committed r59550: <http://trac.webkit.org/changeset/59550>
WebKit Commit Bot
Comment 6 2010-05-15 13:04:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.