Pages that use hardware acceleration don't repaint after waking computer from sleep

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Adam Roben (:aroben)]

To reproduce:

1. Go to <http://webkit.org/blog-files/3d-transforms/poster-circle.html>
2. Put your computer to sleep
3. Wake the computer back up

The page never repaints (until you navigate somewhere else, or reload).

The problem is that WKCACFLayerRenderer doesn't respond to lost devices correctly. See <http://msdn.microsoft.com/en-us/library/bb174714(v=VS.85).aspx>.

[Adam Roben (:aroben)]

<rdar://problem/7986906>

[Adam Roben (:aroben)]

Created attachment 56151 [details]
Periodically try to reset a lost IDirect3DDevice9 until we succeed

[John Sullivan]

Comment on attachment 56151 [details]
Periodically try to reset a lost IDirect3DDevice9 until we succeed

> -    resetDevice();
> +    resetDevice(ChangedWindowSize);

Is it worth asserting that this call returns true?

r+

[Eric Seidel (no email)]

Attachment 56151 [details] was posted by a committer and has review+, assigning to Adam Roben for commit.

[Adam Roben (:aroben)]

(In reply to comment #3)
> (From update of attachment 56151 [details])
> > -    resetDevice();
> > +    resetDevice(ChangedWindowSize);
> 
> Is it worth asserting that this call returns true?

No. Resetting might fail at this point (e.g., if the device became lost sometime since the last time we rendered), so we can't assert that it doesn't. But we don't need to worry here whether it failed or not; if it did fail, we'll try to reset again before we next render. I'll add a comment about this.

Thanks for the review!

[Adam Roben (:aroben)]

Committed r59610: <http://trac.webkit.org/changeset/59610>