Bug 39137

Summary:

Make unsplittable layers (like <video>) position and paginate correctly in multi-column layout.

Product:

WebKit

Reporter:

Dave Hyatt <hyatt>

Component:

CSS

Assignee:

Dave Hyatt <hyatt>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, ddkilzer, eric, ossy, simon.fraser, webkit.review.bot

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	simon.fraser: review+

Dave Hyatt

Reported 2010-05-14 14:33:50 PDT

Elements like <video> don't work with multi-column layouts, since they don't get positioned properly when they occur in columns 2 or higher.

Attachments
Patch (103.59 KB, patch) 2010-05-14 14:55 PDT, Dave Hyatt	simon.fraser: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Dave Hyatt

Comment 1 2010-05-14 14:55:03 PDT

Created attachment 56114 [details] Patch

WebKit Review Bot

Comment 2 2010-05-14 14:56:31 PDT

Attachment 56114 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebCore/rendering/RenderLayer.cpp:3430: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Total errors found: 1 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.

Simon Fraser (smfr)

Comment 3 2010-05-14 16:49:55 PDT

Comment on attachment 56114 [details] Patch r=me but ideally I'd like to see this split into independent patches.

Simon Fraser (smfr)

Comment 4 2010-05-14 19:06:34 PDT

This may fix bug 25455 and bug 21049.

Dave Hyatt

Comment 5 2010-05-14 20:17:42 PDT

Landed in r59513.

WebKit Review Bot

Comment 6 2010-05-14 20:50:41 PDT

http://trac.webkit.org/changeset/59513 might have broken Qt Linux Release

Adam Barth

Comment 7 2010-05-14 22:15:13 PDT

This patch added a new test that fails on Qt. Is anyone around to address this issue?

Adam Barth

Comment 8 2010-05-14 22:35:19 PDT

I've skipped the test in Qt in http://trac.webkit.org/changeset/59517. I have no idea whether we just need a Qt baseline or whether something is really screwed up. I feel like it's quite inconsiderate to commit at 8pm on a Friday and then disappear without seeing if your patch breaks other ports.

David Kilzer (:ddkilzer)

Comment 9 2010-05-15 09:12:58 PDT

<rdar://problem/7960260>

Dave Hyatt

Comment 10 2010-05-15 16:39:47 PDT

(In reply to comment #8) > I've skipped the test in Qt in http://trac.webkit.org/changeset/59517. I have no idea whether we just need a Qt baseline or whether something is really screwed up. > > I feel like it's quite inconsiderate to commit at 8pm on a Friday and then disappear without seeing if your patch breaks other ports. Wah.

Dave Hyatt

Comment 11 2010-05-15 17:10:22 PDT

I didn't break anything. There's no bug here. The test just needs a new result, and I don't run Qt so I can't check it in.

Note You need to log in before you can comment on or make changes to this bug.