Bug 39135

Summary: Rename GenericWorkerTask.h to CrossThreadTask.h and move it to dom directory
Product: WebKit Reporter: Jian Li <jianli>
Component: WebCore JavaScriptAssignee: Jian Li <jianli>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, dimich, levin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed Patch
levin: review-, jianli: commit-queue-
Proposed Patch levin: review+, jianli: commit-queue-

Jian Li
Reported 2010-05-14 14:01:57 PDT
This is the second patch to reposition GenericWorkerTask so that it can be used by more components.
Attachments
Proposed Patch (55.07 KB, patch)
2010-05-14 14:03 PDT, Jian Li 		levin: review-
jianli: commit-queue-
DetailsFormatted DiffDiff
Proposed Patch (55.88 KB, patch)
2010-05-18 18:10 PDT, Jian Li 		levin: review+
jianli: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jian Li
Comment 1 2010-05-14 14:03:46 PDT
Created attachment 56108 [details] Proposed Patch
David Levin
Comment 2 2010-05-14 14:49:42 PDT
Comment on attachment 56108 [details] Proposed Patch It looks good to me except for the fact that WebCore/WebCore.xcodeproj/project.pbxproj isn't fixed up completely. For example, the files haven't been moved to the correct new directory. I think I know how to fix this by hand (look for "children =" in that file), but in general this points out to me that the pbxproj file is tricky to edit by hand. I'd suggest that it would be better to open this file in xcode and delete the file and re-add it (if possible).
Alexey Proskuryakov
Comment 3 2010-05-14 19:43:31 PDT
CrossThreadCopier is not something I'd expect to see in "GenericTask". Is that something you plan to change next?
Jian Li
Comment 4 2010-05-18 18:10:14 PDT
Created attachment 56436 [details] Proposed Patch Fixed WebCore.xcodeproj/project.pbxproj. Also changed to rename to CrossThreadTask.
Jian Li
Comment 5 2010-05-20 11:00:02 PDT
Committed as http://trac.webkit.org/changeset/59849.
Note You need to log in before you can comment on or make changes to this bug.