Bug 39126

Summary: Update notifications test results
Product: WebKit Reporter: Yael <yael>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch. none

Yael
Reported 2010-05-14 11:26:13 PDT
Some of the notifications test results have extra or missing line endings. new-run-webkit-tests does not check for line endings and since these test run only in test-shell in Chromium, this has not been a problem until now. Please see https://bugs.webkit.org/show_bug.cgi?id=36983 for more info.
Attachments
Patch. (2.10 KB, patch)
2010-05-14 11:34 PDT, Yael 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yael
Comment 1 2010-05-14 11:34:46 PDT
Created attachment 56089 [details] Patch.
WebKit Commit Bot
Comment 2 2010-05-15 02:33:14 PDT
Comment on attachment 56089 [details] Patch. Clearing flags on attachment: 56089 Committed r59530: <http://trac.webkit.org/changeset/59530>
WebKit Commit Bot
Comment 3 2010-05-15 02:33:19 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 4 2010-05-15 04:09:17 PDT
http://trac.webkit.org/changeset/59530 might have broken GTK Linux 32-bit Release The following changes are on the blame list: http://trac.webkit.org/changeset/59530 http://trac.webkit.org/changeset/59531 http://trac.webkit.org/changeset/59532 http://trac.webkit.org/changeset/59533
Yael
Comment 5 2010-05-15 05:00:08 PDT
(In reply to comment #4) > http://trac.webkit.org/changeset/59530 might have broken GTK Linux 32-bit Release > The following changes are on the blame list: > http://trac.webkit.org/changeset/59530 > http://trac.webkit.org/changeset/59531 > http://trac.webkit.org/changeset/59532 > http://trac.webkit.org/changeset/59533 This patch added missing line endings to notifications tests, which are skipped on GTK, I doubt it is the cause of the accessibility test failure.
Note You need to log in before you can comment on or make changes to this bug.