Bug 39124 – XMLHttpRequest.setRequestHeader shouldn't be custom

• Component: New Bugs
• Status: RESOLVED FIXED

[Adam Barth]

XMLHttpRequest.setRequestHeader shouldn't be custom

[Adam Barth]

Created attachment 56086 [details]
Patch

[Adam Barth]

Comment on attachment 56086 [details]
Patch

Thanks.

[Alexey Proskuryakov]

+        // FIXME: RequiresAllArguments is probably bogus here.

I don't know what to do with this FIXME when I see it. On what grounds can the FIXME be removed, if it's not bogus?

I think that a FIXME should contain a specific claim that can be addressed or rejected, but "bogus" is open ended.

[WebKit Commit Bot]

Comment on attachment 56086 [details]
Patch

Rejecting patch 56086 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing/iframes', '--quiet']" exit_code: 1
Last 500 characters of output:
piling Java tests
make: Nothing to be done for `default'.
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Skipped list contained 'compositing/iframes/composited-iframe.html', but no file of that name could be found
Testing 18341 test cases.
http/tests/xmlhttprequest/exceptions.html -> failed

Exiting early after 1 failures. 18175 tests run.
460.84s total testing time

18174 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
11 test cases (<1%) had stderr output

Full output: http://webkit-commit-queue.appspot.com/results/2321113

[Adam Barth]

I see.  We're supposed to throw on too few arguments here.  There are three behaviors:

1) Treat missing arguments as undefined.
2) Return undefined when arguments are missing.
3) Throw a syntax error when arguments are missing.

Looks like we need to mint a new IDL attribute so we can select which of the three we want for a given method.

[Adam Barth]

Created attachment 56163 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 56163 [details]
Patch for landing

Clearing flags on attachment: 56163

Committed r59557: <http://trac.webkit.org/changeset/59557>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.