Bug 39120

Summary: Web Inspector: cleanup styles for help screen
Product: WebKit Reporter: Andrey Kosyakov <caseq>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bweinstein, commit-queue, joepeck, keishi, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
none
screenshot none

Description Andrey Kosyakov 2010-05-14 08:48:13 PDT 
- got rid of absolute positioning in favor of flex boxes where possible 
- more comprehensible window names
- added subtle shadow for help window
Comment 1 Andrey Kosyakov 2010-05-14 09:09:48 PDT 
Created attachment 56077 [details]
patch
Comment 2 Andrey Kosyakov 2010-05-14 09:50:24 PDT 
Created attachment 56081 [details]
screenshot
Comment 3 Joseph Pecoraro 2010-05-15 00:53:43 PDT 
Hey Andrey. Looking better. Could more keycodes be replaced?

This list looks pretty accurate to me:
http://www.danrodney.com/mac/index.html

  Esc = ⎋ = "\u238b"
  Ctrl = ⌃ = "\u2303"
  Return 1 = ⏎ = "\u23ce"
  Return 2 = ↩ = "\u21a9"
  Tab = ⇥ = "\u21e5"
  PageUp = ⇞ = "\u21de"
  Page Down: ⇟ = "\u21df"

Where you have "Enter" should be "Return" for Mac.

Feel free to open up another bug now that you already have a patch reviewed for this.
Comment 4 Andrey Kosyakov 2010-05-15 05:06:32 PDT 
(In reply to comment #3)
> Hey Andrey. Looking better. Could more keycodes be replaced?

Yup, thanks for the handy code points! The related change is here:

https://bugs.webkit.org/show_bug.cgi?id=39158
Comment 5 WebKit Commit Bot 2010-05-15 15:08:35 PDT 
Comment on attachment 56077 [details]
patch

Clearing flags on attachment: 56077

Committed r59553: <http://trac.webkit.org/changeset/59553>
Comment 6 WebKit Commit Bot 2010-05-15 15:08:41 PDT 
All reviewed patches have been landed.  Closing bug.