Bug 39040

Summary:

[GTK] Get more mouse tests passing

Product:

WebKit

Reporter:

Martin Robinson <mrobinson>

Component:

WebKitGTK

Assignee:

Martin Robinson <mrobinson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, eric, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Bug Depends on:

38853

Bug Blocks:

Attachments:

Description	Flags
Properly map EventSender button number to GDK button number	mrobinson: commit-queue-
Updated patch (with baselines)	mrobinson: commit-queue-
Updated patch	xan.lopez: review+, mrobinson: commit-queue-

Martin Robinson

Reported 2010-05-12 20:36:37 PDT

We skip quite a few mouse tests. If fixes for the DRT land, hopefully we can start unskipping them.

Attachments
Properly map EventSender button number to GDK button number (6.62 KB, patch) 2010-05-12 20:44 PDT, Martin Robinson	mrobinson: commit-queue-	Details Formatted Diff Diff
Updated patch (with baselines) (9.84 KB, patch) 2010-05-12 20:46 PDT, Martin Robinson	mrobinson: commit-queue-	Details Formatted Diff Diff
Updated patch (10.17 KB, patch) 2010-05-14 09:14 PDT, Martin Robinson	xan.lopez: review+ mrobinson: commit-queue-	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Martin Robinson

Comment 1 2010-05-12 20:44:04 PDT

Created attachment 55934 [details] Properly map EventSender button number to GDK button number Added the first patch for this work. Properly mapping EventSender button number to GDK button number fixes several tests.

Martin Robinson

Comment 2 2010-05-12 20:46:53 PDT

Created attachment 55935 [details] Updated patch (with baselines) Forgot to add new baselines. I've added them to the patch.

Martin Robinson

Comment 3 2010-05-14 09:14:03 PDT

Created attachment 56078 [details] Updated patch

Xan Lopez

Comment 4 2010-05-14 09:34:42 PDT

Comment on attachment 56078 [details] Updated patch Looks good to me when the other patches land.

Adam Barth

Comment 5 2010-05-14 23:31:26 PDT

Attachment 56078 [details] was posted by a committer and has review+, assigning to Martin Robinson for commit.

Martin Robinson

Comment 6 2010-06-01 11:05:11 PDT

Committed r60489: <http://trac.webkit.org/changeset/60489>

WebKit Review Bot

Comment 7 2010-06-01 11:22:28 PDT

http://trac.webkit.org/changeset/60489 might have broken GTK Linux 32-bit Release and GTK Linux 64-bit Release The following changes are on the blame list: http://trac.webkit.org/changeset/60489 http://trac.webkit.org/changeset/60490

Note You need to log in before you can comment on or make changes to this bug.