Bug 39040

Summary: [GTK] Get more mouse tests passing
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Bug Depends on: 38853    
Bug Blocks:    
Attachments:
Description Flags
Properly map EventSender button number to GDK button number
mrobinson: commit-queue-
Updated patch (with baselines)
mrobinson: commit-queue-
Updated patch xan.lopez: review+, mrobinson: commit-queue-

Description Martin Robinson 2010-05-12 20:36:37 PDT 
We skip quite a few mouse tests. If fixes for the DRT land, hopefully we can start unskipping them.
Comment 1 Martin Robinson 2010-05-12 20:44:04 PDT 
Created attachment 55934 [details]
Properly map EventSender button number to GDK button number

Added the first patch for this work. Properly mapping EventSender button number to GDK button number fixes several tests.
Comment 2 Martin Robinson 2010-05-12 20:46:53 PDT 
Created attachment 55935 [details]
Updated patch (with baselines)

Forgot to add new baselines. I've added them to the patch.
Comment 3 Martin Robinson 2010-05-14 09:14:03 PDT 
Created attachment 56078 [details]
Updated patch
Comment 4 Xan Lopez 2010-05-14 09:34:42 PDT 
Comment on attachment 56078 [details]
Updated patch

Looks good to me when the other patches land.
Comment 5 Adam Barth 2010-05-14 23:31:26 PDT 
Attachment 56078 [details] was posted by a committer and has review+, assigning to Martin Robinson for commit.
Comment 6 Martin Robinson 2010-06-01 11:05:11 PDT 
Committed r60489: <http://trac.webkit.org/changeset/60489>
Comment 7 WebKit Review Bot 2010-06-01 11:22:28 PDT 
http://trac.webkit.org/changeset/60489 might have broken GTK Linux 32-bit Release and GTK Linux 64-bit Release
The following changes are on the blame list:
http://trac.webkit.org/changeset/60489
http://trac.webkit.org/changeset/60490