Bug 39033

Summary:

Composited plug-ins can cause missed painting

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

Layout and Rendering

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, eric, webkit.review.bot

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
Patch	hyatt: review+

Simon Fraser (smfr)

Reported 2010-05-12 16:57:08 PDT

If you load a page with Flash 10.1 in iframes, and then you bring that tab to the front, we assert and bail from FrameView::paintContents() here: ASSERT(!needsLayout()); if (needsLayout()) return; This is because the iframe-compositing code is doing a setNeedsStyleRecalc() on the root frame from inside the -viewWillDraw machinery, but after that root frame has done layout. So by the time it paints, we've marked it as needing layout.

Attachments
Patch (21.49 KB, patch) 2010-05-12 17:17 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Patch (21.62 KB, patch) 2010-05-12 18:23 PDT, Simon Fraser (smfr)	hyatt: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.