Summary: | Don't clear yellow autofill highlight until user edits value | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jens Alfke <jens> | ||||
Component: | Forms | Assignee: | Jens Alfke <jens> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Minor | CC: | commit-queue, sullivan | ||||
Priority: | P3 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Jens Alfke
2010-05-12 15:59:09 PDT
Created attachment 55912 [details]
patch
FYI, I asked about this change on webkit-dev, and John Sullivan was OK with it:
"It seems reasonable to me that the autofilled property is only cleared when the text is modified by the user. Since it is a visible change in the behavior, there's always a chance that it will not sit well with everyone and we might eventually have to allow for both behaviors somehow. But it seems like a small enough behavior change that it's unlikely that anyone will care strongly about it."
I think we could implement the old behavior on top of the new code by having the client notice the focus event and explicitly call setAutofilled(false), so that makes the new code seem even safer than I previously thought. Comment on attachment 55912 [details]
patch
This seems safe enough.
Comment on attachment 55912 [details] patch Clearing flags on attachment: 55912 Committed r59472: <http://trac.webkit.org/changeset/59472> All reviewed patches have been landed. Closing bug. |