Summary: | CSSParser::parseColor() shouldn't alter 'color' unless passed a valid color string. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||||
Component: | CSS | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | CLOSED FIXED | ||||||||
Severity: | Normal | CC: | benjamin, commit-queue, darin, hausmann, laszlo.gombos | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 35784 | ||||||||
Attachments: |
|
Description
Andreas Kling
2010-05-12 15:54:14 PDT
Created attachment 55910 [details]
Proposed patch
I can't think of a good way to LayoutTest this, but it doesn't break any existing tests and is obviously correct (famous last words..) Comment on attachment 55910 [details]
Proposed patch
How did you check all the call sites to make sure that none were depending on the old behavior?
Created attachment 55927 [details]
Proposed patch v2
By insufficient grepping, apparently. :(
Updated patch to remove dependency on old behavior.
Comment on attachment 55927 [details]
Proposed patch v2
Looks OK. r=me
Comment on attachment 55927 [details] Proposed patch v2 Clearing flags on attachment: 55927 Committed r59473: <http://trac.webkit.org/changeset/59473> All reviewed patches have been landed. Closing bug. |