Bug 38990

Summary: Touch events are disabled by default when using V8.
Product: WebKit Reporter: Ben Murdoch <benm>
Component: WebCore Misc.Assignee: Ben Murdoch <benm>
Status: RESOLVED FIXED    
Severity: Normal CC: andreip, android-webkit-unforking, commit-queue, dglazkov, fishd, gdk, steveblock
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch. none

Ben Murdoch
Reported 2010-05-12 07:30:10 PDT
With https://bugs.webkit.org/show_bug.cgi?id=37485 and https://bugs.webkit.org/show_bug.cgi?id=38392 a runtime flag was added to configure support for touch events and it is false by default, i.e. touch events are turned off. This means touch events no longer work on Android after this change. Chromium configures this flag independently of the WebCore default and the code inside RuntimeEnabledFeatures.h is protected by the ENABLE(TOUCH_EVENTS) compile time guard. I think it is safe therefore to make the default for this flag inside WebCore true. Patch to follow.
Attachments
Patch. (1.39 KB, patch)
2010-05-12 07:56 PDT, Ben Murdoch 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ben Murdoch
Comment 1 2010-05-12 07:56:35 PDT
Created attachment 55846 [details] Patch.
Steve Block
Comment 2 2010-05-12 08:00:42 PDT
> I think it is safe therefore to make the default for this flag inside WebCore > true. It seems that all runtime-enabled features that are also guarded by a compile flag should default to 'on', particularly if the default is overriden by chromium anyway.
Darin Fisher (:fishd, Google)
Comment 3 2010-05-12 09:16:56 PDT
Comment on attachment 55846 [details] Patch. R=me, and I agree that it makes sense to enable the rest by default as well. That can be a separate patch though.
WebKit Commit Bot
Comment 4 2010-05-14 02:50:28 PDT
Comment on attachment 55846 [details] Patch. Clearing flags on attachment: 55846 Committed r59459: <http://trac.webkit.org/changeset/59459>
WebKit Commit Bot
Comment 5 2010-05-14 02:50:39 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.