Bug 38979

Summary:

Display queue position inside EWS bubbles

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, commit-queue, ojan

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
work in progress	none
Patch	none

Eric Seidel (no email)

Reported 2010-05-12 00:51:27 PDT

Display queue position inside EWS bubbles

Attachments
work in progress (18.82 KB, patch) 2010-05-12 00:57 PDT, Eric Seidel (no email)	no flags	Details Formatted Diff Diff
Patch (25.97 KB, patch) 2010-05-13 05:43 PDT, Eric Seidel (no email)	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Eric Seidel (no email)

Comment 1 2010-05-12 00:57:01 PDT

Created attachment 55817 [details] work in progress

Eric Seidel (no email)

Comment 2 2010-05-13 05:43:42 PDT

Created attachment 55965 [details] Patch

Adam Barth

Comment 3 2010-05-14 12:37:43 PDT

Comment on attachment 55965 [details] Patch WebKitTools/QueueStatusServer/model/attachment.py:107 + # FIXME: Should we be mem-caching this? Yes. I don't think caching in Python memory does much. Ok. We might want to invest in testing for QueueStatusServer. There's probably a way to test it with the appengine test server.

Eric Seidel (no email)

Comment 4 2010-05-14 12:41:15 PDT

I agree. I considered adding testing for this but was unsure how to wire it up. I will think more about it as I make more of these changes.

WebKit Commit Bot

Comment 5 2010-05-15 03:42:59 PDT

Comment on attachment 55965 [details] Patch Clearing flags on attachment: 55965 Committed r59534: <http://trac.webkit.org/changeset/59534>

WebKit Commit Bot

Comment 6 2010-05-15 03:43:05 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.