|Summary:||Web Inspector: Shorthand Properties Getting Deleted When Editing|
|Product:||WebKit||Reporter:||Joseph Pecoraro <joepeck>|
|Component:||Web Inspector (Deprecated)||Assignee:||Nobody <webkit-unassigned>|
|Severity:||Normal||CC:||bweinstein, joepeck, keishi, pfeldman, pmuellr, rik, timothy, yurys|
|Version:||528+ (Nightly build)|
Description Joseph Pecoraro 2010-05-11 17:39:57 PDT
Shorthand properties are getting deleted when editing. Very annoying!
Comment 1 Joseph Pecoraro 2010-05-11 17:42:57 PDT
Created attachment 55786 [details] [PATCH] Easy Fix Easy!
Comment 2 Joseph Pecoraro 2010-05-11 17:55:35 PDT
Comment 3 Joseph Pecoraro 2010-05-11 17:58:56 PDT
Created attachment 55788 [details] [TEST]: Sample Test Case Steps to Reproduce: 1. Open Test Case html file 2. Right Click + Inspect the Text 3. Double Click to Edit the margin value 4. Put cursor by the number 5. Push Up/Down a few times Expected Results: Only the margin should change. Actual Results: The margin changes, but after a few increments/decrements the border is deleted, without warning! Deselecting and Reselecting the original node shows that it has disappeared.
Comment 4 Timothy Hatcher 2010-05-11 19:41:19 PDT
Comment on attachment 55786 [details] [PATCH] Easy Fix Consider landing before the CQ gets to it.
Comment 5 Pavel Feldman 2010-05-11 21:51:20 PDT
Thanks for fixing it. Any chance we get a test for this?
Comment 6 Joseph Pecoraro 2010-05-11 22:36:18 PDT
(In reply to comment #5) > Thanks for fixing it. Any chance we get a test for this? Do you mean an inspector test? I gave this only a brief thought at the time but figured since it was such a straight forward fix (if shorthand -> getShorthandValue) that I'd just put up the patch. But, now that you mention it, I think it would be nice to have a patch testing the styles output in general. To catch a case like this style manipulation functions can be run. I'll land this, because I feel its something urgent (this hits me quite a bit) and open up a follow up bug that styles need more coverage.