Bug 38958

Summary:

Web Inspector: Shorthand Properties Getting Deleted When Editing

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector (Deprecated)

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bweinstein, joepeck, keishi, pfeldman, pmuellr, rik, timothy, yurys

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Easy Fix	timothy: review+, joepeck: commit-queue-
[TEST]: Sample Test Case	none

Joseph Pecoraro

Reported 2010-05-11 17:39:57 PDT

Shorthand properties are getting deleted when editing. Very annoying!

Attachments
[PATCH] Easy Fix (1.34 KB, patch) 2010-05-11 17:42 PDT, Joseph Pecoraro	timothy: review+ joepeck: commit-queue-	Details Formatted Diff Diff
[TEST]: Sample Test Case (89 bytes, text/html) 2010-05-11 17:58 PDT, Joseph Pecoraro	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Joseph Pecoraro

Comment 1 2010-05-11 17:42:57 PDT

Created attachment 55786 [details] [PATCH] Easy Fix Easy!

Joseph Pecoraro

Comment 2 2010-05-11 17:55:35 PDT

<radr://7972069>

Joseph Pecoraro

Comment 3 2010-05-11 17:58:56 PDT

Created attachment 55788 [details] [TEST]: Sample Test Case Steps to Reproduce: 1. Open Test Case html file 2. Right Click + Inspect the Text 3. Double Click to Edit the margin value 4. Put cursor by the number 5. Push Up/Down a few times Expected Results: Only the margin should change. Actual Results: The margin changes, but after a few increments/decrements the border is deleted, without warning! Deselecting and Reselecting the original node shows that it has disappeared.

Timothy Hatcher

Comment 4 2010-05-11 19:41:19 PDT

Comment on attachment 55786 [details] [PATCH] Easy Fix Consider landing before the CQ gets to it.

Pavel Feldman

Comment 5 2010-05-11 21:51:20 PDT

Thanks for fixing it. Any chance we get a test for this?

Joseph Pecoraro

Comment 6 2010-05-11 22:36:18 PDT

(In reply to comment #5) > Thanks for fixing it. Any chance we get a test for this? Do you mean an inspector test? I gave this only a brief thought at the time but figured since it was such a straight forward fix (if shorthand -> getShorthandValue) that I'd just put up the patch. But, now that you mention it, I think it would be nice to have a patch testing the styles output in general. To catch a case like this style manipulation functions can be run. I'll land this, because I feel its something urgent (this hits me quite a bit) and open up a follow up bug that styles need more coverage.

Joseph Pecoraro

Comment 7 2010-05-11 22:51:42 PDT

Committed r59210 M WebCore/ChangeLog M WebCore/inspector/front-end/DOMAgent.js r59210 = 0348fb02fde32b1c173f3f2d1e03f3b0d5662603 (refs/remotes/trunk) http://trac.webkit.org/changeset/59210

Note You need to log in before you can comment on or make changes to this bug.