Bug 38947

Summary:

[chromium] Expose volume through WebMediaPlayerClient

Product:

WebKit

Reporter:

James Simonsen <simonjam>

Component:

WebKit API

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, fishd, levin, scherkus

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Adds needed accessors to WebMediaPlayerClient	none
Fixed order to match header file	none
Patch	none

James Simonsen

Reported 2010-05-11 16:43:08 PDT

This is the WebKit portion of the fix to: http://code.google.com/p/chromium/issues/detail?id=33023 We need to expose the media volume through WebMediaPlayerClient. This is so that Chromium can get the correct volume setting before starting playback.

Attachments
Adds needed accessors to WebMediaPlayerClient (1.56 KB, patch) 2010-05-11 17:24 PDT, James Simonsen	no flags	Details Formatted Diff Diff
Fixed order to match header file (1.67 KB, patch) 2010-05-12 12:04 PDT, James Simonsen	no flags	Details Formatted Diff Diff
Patch (2.56 KB, patch) 2010-05-12 15:55 PDT, James Simonsen	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

James Simonsen

Comment 1 2010-05-11 17:24:13 PDT

Created attachment 55783 [details] Adds needed accessors to WebMediaPlayerClient

David Levin

Comment 2 2010-05-11 17:58:31 PDT

This looks fine to scherkus@, since it touches the Chromium public api, I'll leave the final r+ to fishd.

Darin Fisher (:fishd, Google)

Comment 3 2010-05-11 21:33:07 PDT

Comment on attachment 55783 [details] Adds needed accessors to WebMediaPlayerClient WebKit/chromium/src/WebMediaPlayerClientImpl.cpp:396 + float WebMediaPlayerClientImpl::volume() const It looks like you have not inserted this method definition after the definition of sawUnsupportedTracks. Please fix that so that methods in the .cpp file are defined in the same order in which they are declared in the .h file. Thanks!

James Simonsen

Comment 4 2010-05-12 12:04:37 PDT

Created attachment 55883 [details] Fixed order to match header file

Eric Seidel (no email)

Comment 5 2010-05-12 12:15:19 PDT

Comment on attachment 55883 [details] Fixed order to match header file No ChangeLog. r- See http://webkit.org/coding/contributing.html

James Simonsen

Comment 6 2010-05-12 15:55:04 PDT

Created attachment 55909 [details] Patch

WebKit Commit Bot

Comment 7 2010-05-14 05:16:57 PDT

Comment on attachment 55909 [details] Patch Clearing flags on attachment: 55909 Committed r59466: <http://trac.webkit.org/changeset/59466>

WebKit Commit Bot

Comment 8 2010-05-14 05:17:05 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.