| Summary: | -[DOMCSSStyleDeclaration cssText] is not implemented | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dan Wood <dwood> | ||||||
| Component: | DOM | Assignee: | Darin Adler <darin> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | nagar28496, todd | ||||||
| Priority: | P2 | ||||||||
| Version: | 420+ | ||||||||
| Hardware: | Mac | ||||||||
| OS: | OS X 10.4 | ||||||||
| Attachments: |
|
||||||||
Created attachment 2875 [details]
Implement cssText for most rules
The cpp file uses namespace DOM so no need for DOM::DOMString there. Can you attach a new patch that minimizes the extra DOM::? Thanks. Created attachment 2921 [details]
Address comments
Comment on attachment 2921 [details]
Address comments
It's a little annoying that CSSComputedStyleDeclarationImpl::cssText returns
something with a trailing space.
Is there some better way to share the getPropertyName function than putting
this extern declaration in the .cpp file?
The test looks good to me.
I'm going to mark this review+ even though I have those two minor
questions/comments above.
|
The underlying implementation of -[DOMCSSStyleDeclaration cssText] is not implemented. Test case.... Take a node and ask for its style, then print it out. DOMCSSStyleDeclaration *style = [[self DOMDocument] getComputedStyle:(DOMElement *) node :@""]; NSLog(@"cssText = %@", [style cssText]); Result: ================= ERROR: unimplemented (/Volumes/dwood/dev/WK/WebCore/khtml/css/css_computedstyle.cpp:289 virtual DOM::DOMString DOM::CSSComputedStyleDeclarationImpl::cssText() const) ================= Here is the offending code, in css_computedstyle.cpp: DOMString CSSComputedStyleDeclarationImpl::cssText() const { ERROR("unimplemented"); return DOMString(); }