Bug 38925 – Web Inspector: Timeline. Send Request records initiated by JS have no parent.

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Ilya Tikhonovsky]

%SUBJ%

[Ilya Tikhonovsky]

It is possible to force Resource Request from JS code.
But these requests are not connected to the corresponding function call and have no caller info.

[Ilya Tikhonovsky]

Created attachment 55745 [details]
[patch] initial version.

has binary changes.
New record type Delayed Request is introduced.
It is generating each time when loader is trying to pass low priority resource request via message queue.
Resource url is used as identifier as far as ResourceRequest object and it's identifier is not exist at the moment.
Delayed Request and Send Request are linked together at front-end side.

[Pavel Feldman]

Comment on attachment 55745 [details]
[patch] initial version.

WebCore/inspector/TimelineRecordFactory.cpp:135
 +  	data.set("url", request->cachedResource()->url());
Indent, null check missing.

[Pavel Feldman]

Comment on attachment 55745 [details]
[patch] initial version.


WebCore/inspector/front-end/TimelineAgent.js:57
 +      DelayedRequest : 20
SchedulePendingRequests ?

WebCore/loader/loader.cpp:153
 +                  agent->didDelayedRequest(request);
I'd use more strict binding to sendrequest. Using the "url + cached resource address" will already be less ambiguous.

[Ilya Tikhonovsky]

Created attachment 55836 [details]
[patch] second iteration

DelayedRequest was renamed to ScheduleResourceRequest.
It is not possible to use Request address as part of the key because we have no Request address at SendResourceRequest.
We definitely have a valid CachedResource pointer and can use url method without implicit check.

[Ilya Tikhonovsky]

Committed r59237
	M	WebCore/ChangeLog
	M	WebCore/inspector/InspectorTimelineAgent.cpp
	M	WebCore/inspector/TimelineRecordFactory.h
	M	WebCore/inspector/front-end/TimelineAgent.js
	M	WebCore/inspector/front-end/TimelinePanel.js
	M	WebCore/inspector/InspectorTimelineAgent.h
	M	WebCore/inspector/TimelineRecordFactory.cpp
	M	WebCore/English.lproj/localizedStrings.js
	M	WebCore/loader/loader.cpp
	M	LayoutTests/inspector/timeline-enum-stability-expected.txt
	M	LayoutTests/ChangeLog
r59237 = 07361e849c4b0674708f3b9a3966e9e09fa09ee3 (refs/remotes/trunk)