Bug 38917

Summary:

[Qt] Cleanup SharedBuffer::createWithContentsOfFile

Product:

WebKit

Reporter:

Patrick R. Gansterer <paroga>

Component:

WebCore Misc.

Assignee:

Patrick R. Gansterer <paroga>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, jesus, kenneth, markus

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
The patch	none

Patrick R. Gansterer

Reported 2010-05-11 11:04:38 PDT

see patch

Attachments
The patch (1.40 KB, patch) 2010-05-11 11:06 PDT, Patrick R. Gansterer	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Patrick R. Gansterer

Comment 1 2010-05-11 11:06:24 PDT

Markus Goetz

Comment 2 2010-05-12 00:52:27 PDT

Looks good to me.

Eric Seidel (no email)

Comment 3 2010-05-20 01:16:11 PDT

Comment on attachment 55723 [details] The patch LGTM.

WebKit Commit Bot

Comment 4 2010-05-22 12:11:06 PDT

Comment on attachment 55723 [details] The patch Clearing flags on attachment: 55723 Committed r60009: <http://trac.webkit.org/changeset/60009>

WebKit Commit Bot

Comment 5 2010-05-22 12:11:12 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.