Bug 38872

Summary: Executive.kill_* do not work with windows python
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, eric, ojan, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch levin: review+

Eric Seidel (no email)
Reported 2010-05-10 15:26:08 PDT
Executive.kill_* do not work with windows python
Attachments
Patch (4.00 KB, patch)
2010-05-10 15:31 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Patch (4.15 KB, patch)
2010-05-10 15:35 PDT, Eric Seidel (no email) 		levin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2010-05-10 15:31:07 PDT
Created attachment 55609 [details] Patch
Eric Seidel (no email)
Comment 2 2010-05-10 15:35:55 PDT
Created attachment 55610 [details] Patch
David Levin
Comment 3 2010-05-10 15:44:20 PDT
Comment on attachment 55610 [details] Patch So this patch is s/"windows"/"win32"/ :) ok
Eric Seidel (no email)
Comment 4 2010-05-10 15:48:59 PDT
Committed r59099: <http://trac.webkit.org/changeset/59099>
WebKit Review Bot
Comment 5 2010-05-10 16:19:11 PDT
http://trac.webkit.org/changeset/59099 might have broken GTK Linux 32-bit Release The following changes are on the blame list: http://trac.webkit.org/changeset/59099 http://trac.webkit.org/changeset/59100
Eric Seidel (no email)
Comment 6 2010-05-10 16:25:23 PDT
http://trac.webkit.org/changeset/59100 is to blame.
Note You need to log in before you can comment on or make changes to this bug.