| Summary: | REGRESSION (r59016): plugins/set-status.html fails on Windows | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> | ||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ap, sam, sfalken | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Other | ||||||
| OS: | Windows XP | ||||||
| Attachments: |
|
||||||
|
Description
Adam Roben (:aroben)
2010-05-10 09:05:55 PDT
Created attachment 55558 [details]
Patch
Comment on attachment 55558 [details]
Patch
r=me, because this DRT-only fix can't be wrong, but I don't understand what happened here. Why did %S truncate the text, isn't it supposed to work for UTF-16?
For double safety you may want to check what happens in Safari - is the status text set to what we expect it to?
(In reply to comment #2) > (From update of attachment 55558 [details]) > r=me, because this DRT-only fix can't be wrong, but I don't understand what happened here. Why did %S truncate the text, isn't it supposed to work for UTF-16? I did a little more debugging. %S does "work" for UTF-16. But it converts the input string to a non-wide string using wctomb, which uses the codepage for the current locale. The conversion is failing, which causes printf to bail. I'll add this information to the ChangeLog. > For double safety you may want to check what happens in Safari - is the status text set to what we expect it to? Yes, Safari works as expected. Thanks for the review! Committed r59371: <http://trac.webkit.org/changeset/59371> |