Bug 38803

Summary: webkit-patch rollout throws exception if bug was never confirmed
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch abarth: review+, abarth: commit-queue-

Eric Seidel (no email)
Reported 2010-05-08 10:42:20 PDT
webkit-patch rollout throws exception if bug is already open
Attachments
Patch (5.01 KB, patch)
2010-05-08 10:45 PDT, Eric Seidel (no email) 		abarth: review+
abarth: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2010-05-08 10:45:55 PDT
Created attachment 55480 [details] Patch
Adam Barth
Comment 2 2010-05-08 12:31:39 PDT
Comment on attachment 55480 [details] Patch WebKitTools/Scripts/webkitpy/common/net/bugzilla_unittest.py:38 + class MockBrowser(Mock): This makes the mock very loose. It'd rather we just added the methods we need with their proper API.
Eric Seidel (no email)
Comment 3 2010-05-08 23:17:08 PDT
Attachment 55480 [details] was posted by a committer and has review+, assigning to Eric Seidel for commit.
Eric Seidel (no email)
Comment 4 2010-05-10 13:13:30 PDT
I made it inherit from Mock to match the mocks in mock_tool.py. I'm happy to change it if tighter mocks are the new best-practice?
Adam Barth
Comment 5 2010-05-10 13:29:47 PDT
Yeah. We should change the other mocks not to inherit from Mock too. I just haven't gotten around to it.
Eric Seidel (no email)
Comment 6 2010-05-14 12:19:28 PDT
Committed r59480: <http://trac.webkit.org/changeset/59480>
Note You need to log in before you can comment on or make changes to this bug.