Bug 38768

Summary: SunSpider computes incorrect two-sample t statistics
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: New BugsAssignee: Adam Roben (:aroben) <aroben>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, mjs
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: All   
Attachments:
Description Flags
Patch darin: review+

Adam Roben (:aroben)
Reported 2010-05-07 12:49:48 PDT
SunSpider computes incorrect two-sample t statistics
Attachments
Patch (1.64 KB, patch)
2010-05-07 12:52 PDT, Adam Roben (:aroben) 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2010-05-07 12:52:50 PDT
Created attachment 55410 [details] Patch
Eric Seidel (no email)
Comment 2 2010-05-08 23:16:58 PDT
Attachment 55410 [details] was posted by a committer and has review+, assigning to Adam Roben for commit.
Adam Roben (:aroben)
Comment 3 2010-05-10 06:32:23 PDT
I wonder if we need to somehow communicate that SunSpider was buggy in this way? I guess not, since the t statistics (or any values derived from them) don't get persisted in the run results that people might save for the future; they're only used when actually comparing two runs.
Adam Roben (:aroben)
Comment 4 2010-05-10 07:13:03 PDT
(In reply to comment #3) > I wonder if we need to somehow communicate that SunSpider was buggy in this way? I guess not, since the t statistics (or any values derived from them) don't get persisted in the run results that people might save for the future; they're only used when actually comparing two runs. In fact, my patch doesn't change the versions of SunSpider hosted on webkit.org, so this is definitely not necessary at the moment. I wonder if we should change those versions, though?
Adam Roben (:aroben)
Comment 5 2010-05-13 10:12:05 PDT
Committed r59370: <http://trac.webkit.org/changeset/59370>
Adam Roben (:aroben)
Comment 6 2010-05-13 10:18:46 PDT
Maciej, do you think we should apply this change to the public versions of SunSpider?
Note You need to log in before you can comment on or make changes to this bug.