Summary: | [Chromium] WebFrame::registerPasswordListener shouldn't assert on duplicate listener | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jens Alfke <jens> | ||||||
Component: | WebKit API | Assignee: | Jens Alfke <jens> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Minor | CC: | commit-queue, fishd, webkit.review.bot | ||||||
Priority: | P3 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Jens Alfke
2010-05-07 12:13:20 PDT
Created attachment 55405 [details]
patch
Attachment 55405 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKit/chromium/src/WebFrameImpl.cpp:1950: Missing space before { [whitespace/braces] [5]
Total errors found: 1 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Why not just have registerPasswordListener clobber the existing listener? Or, provide a hasPasswordListener method? It might also be nice to support unregistering a listener (perhaps by passing 0 to registerPasswordListener). Created attachment 55413 [details]
patch 2
Added a space to appease the coding style gods.
Comment on attachment 55413 [details]
patch 2
OK, I'm convinced. It might be nice to provide a way to unregister a listener,
but that doesn't have to be part of this patch, and perhaps we can wait on that
until we have a need for it.
R=me
Comment on attachment 55413 [details] patch 2 Clearing flags on attachment: 55413 Committed r59029: <http://trac.webkit.org/changeset/59029> All reviewed patches have been landed. Closing bug. |