Bug 38762
| Summary: | [Qt] Flash Plugin is not working on mac-cocoa-32 | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jesus Sanchez-Palencia <jesus> |
| Component: | Plug-ins | Assignee: | QtWebKit Unassigned <webkit-qt-unassigned> |
| Status: | CLOSED FIXED | ||
| Severity: | Major | CC: | hausmann, kas.stepanenko, kenneth, luiz, vestbo |
| Priority: | P2 | Keywords: | Qt |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Mac (Intel) | ||
| OS: | OS X 10.5 | ||
Jesus Sanchez-Palencia
Tested on QtLauncher, with Qt 4.7 HEAD d6cb7c903069e1dfde3ffc69649354c97d160b68 and WebKit r58944.
Reproduced on Leopard and Snow Leopard.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Luiz Agostini
Tor Arne, can you have a look at this?
Jesus Sanchez-Palencia
*** Bug 37328 has been marked as a duplicate of this bug. ***
Tor Arne Vestbø
Works fine here. What exactly is not working?
Note that Qt 4.7 is by default built in a Cocoa 64-bit configuration, which does not support Flash.
Kas Stepanenko
I wrote some details in my bug (it is duplicate of this one), may be it can help.
https://bugs.webkit.org/show_bug.cgi?id=37328
Jesus Sanchez-Palencia
(In reply to comment #3)
> Works fine here. What exactly is not working?
>
> Note that Qt 4.7 is by default built in a Cocoa 64-bit configuration, which does not support Flash.
Tested again with WebKit r59602 and Qt 4.7 HEAD 6100e83f3cbf40199da3078c1954a4dc1f77cb8f.
I'm building Qt using '-arch x86', so it is 32 bits, right?
Load www.youtube.com and try to play a video. You will have sound but not the video itself. Works fine with QGraphicsWebView.
Kenneth Rohde Christiansen
If this is a regression, can you pelase bisect and find out what revision broke it? It is a release blocker.
Tor Arne Vestbø
Flash (and youtube in particular for some reason) has been flakey/not-working-too-well on Cocoa-32 in the past. The only properly working configuration right now is Carbon afaik.
Kenneth Rohde Christiansen
(In reply to comment #7)
> Flash (and youtube in particular for some reason) has been flakey/not-working-too-well on Cocoa-32 in the past. The only properly working configuration right now is Carbon afaik.
So you don't consider this a regression?
Tor Arne Vestbø
(In reply to comment #8)
> (In reply to comment #7)
> > Flash (and youtube in particular for some reason) has been flakey/not-working-too-well on Cocoa-32 in the past. The only properly working configuration right now is Carbon afaik.
>
> So you don't consider this a regression?
Not unless it's also failing on Carbon-builds. But I do think we should try to fix it.
Simon Hausmann
Jesus or Tor Arne: Can you try this in a Carbon build and see if it's a regression or not?
Thanks :)
Jesus Sanchez-Palencia
(In reply to comment #10)
> Jesus or Tor Arne: Can you try this in a Carbon build and see if it's a regression or not?
>
> Thanks :)
Works with a Carbon build. Tested with Qt 4.7 HEAD 6982c5e7f9d93d26ab5f241af0a5c6e80cd0e1ff and WebKit trunk r60561.
So it's not a regression. Removing the release blocker.
Tor Arne Vestbø
Got a fix for this
Simon Hausmann
Committed r60621: <http://trac.webkit.org/changeset/60621>
Kenneth Rohde Christiansen
Rocks!
Simon Hausmann
Revision r60621 cherry-picked into qtwebkit-2.0 with commit f595168f2668b95a75ff9faf3829df596f8f3c89