Bug 38754 – REGRESSION(58736?): fast/loader/stateobjects/document-destroyed-navigate-back-with-fragment-scroll.html fails intermittently

• Component: Tools / Tests
• Status: RESOLVED WORKSFORME

[Eric Seidel (no email)]

REGRESSION(58736?): fast/loader/stateobjects/document-destroyed-navigate-back-with-fragment-scroll.html fails intermittently

I believe 58736 is the most likely cause.

The test is recording when the hashChanged event happening.  Now that it's async I suspect that the order is no longer deterministic, thus the failures.

We need to either fix/skip the test or rollout the change.

[Eric Seidel (no email)]

http://build.webkit.org/results/GTK%20Linux%2064-bit%20Debug/r58944%20(5684)/fast/loader/stateobjects/pushstate-with-fragment-urls-and-hashchange-diffs.txt

--- /home/slave/webkitgtk/gtk-linux-64-debug/build/layout-test-results/fast/loader/stateobjects/pushstate-with-fragment-urls-and-hashchange-expected.txt	2010-05-07 06:28:08.119099757 -0700
+++ /home/slave/webkitgtk/gtk-linux-64-debug/build/layout-test-results/fast/loader/stateobjects/pushstate-with-fragment-urls-and-hashchange-actual.txt	2010-05-07 06:28:08.119099757 -0700
@@ -19,8 +19,8 @@
 State popped with event null (type object) and last path component some-other.html?withquery#
 Hash change fired and last path component is some-other.html?withquery#
 State popped with event null (type object) and last path component some-other.html?withquery
-Hash change fired and last path component is some-other.html?withquery
 State popped with event null (type object) and last path component some-other.html
+Hash change fired and last path component is some-other.html
 State popped with event null (type object) and last path component pushstate-with-fragment-urls-and-hashchange.html#
 State popped with event null (type object) and last path component pushstate-with-fragment-urls-and-hashchange.html#
 State popped with event null (type object) and last path component pushstate-with-fragment-urls-and-hashchange.html#otherhash

[Steven Lai]

Then we must have this one fixed
http://bugs.webkit.org/show_bug.cgi?id=36335
and modify this test to use the new argument in order to make this work.

Otherwise, r58736 it would make pushState/popState useless.

[Steven Lai]

it's better to rollback 58736 first then and implement the new interface for hashchange/pushstate event :(

[Brady Eidson]

(In reply to comment #3)
> it's better to rollback 58736 first then and implement the new interface for
> hashchange/pushstate event :(

Fixing 36335 is pretty straightforward, we should just do that really quick.  If the intermittent SnowLeopard failure is getting in the way in the mean time (but I don't think we have a SL ews bot quite yet) then we could skip it, and re-enable when landing the fix for 36335

[Steven Lai]

Filed patch to https://bugs.webkit.org/show_bug.cgi?id=36335

[Jędrzej Nowacki]

I think that the bug 39418 could be related to this one.

[Jędrzej Nowacki]

I'm closing the bug, because I think that it is not valid anymore. Feel free to reopen it in case if I'm wrong.

Checked with: http://build.webkit.org/results/GTK Linux 64-bit Debug/r60144 (6316)/fast/