Bug 38753 – Web Inspector: Autocompletion in console is not usable because it is not add to the entered text the common prefix of suggestions.

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Ilya Tikhonovsky]

As example if you entered $0.getE then getElementByClassName will be suggested as gray text.
If you press tab then getElementByClassName be suggested again and lementByClassName becomes selected as black text with selection background.
Really after pressing the TAB the next suggestion should be selected (getElementByTagName) and only flexible part of suggestions should be selected.
In this case it should be TagName because getElementBy is the common part for all getE prefix suggestions.

[Ilya Tikhonovsky]

Created attachment 55378 [details]
[patch] Initial version.

[Ilya Tikhonovsky]

Created attachment 55379 [details]
screencast

[Timothy Hatcher]

Comment on attachment 55378 [details]
[patch] Initial version.

WebCore/inspector/front-end/TextPrompt.js:234
 +                      for (var j = wordPrefixLength; j < lastIndex; ++j)
Need {} around the body, since it is multiline (per style guide.)

WebCore/inspector/front-end/TextPrompt.js:248
 +                      for (var i = 0; i < completions.length; ++i)
Need {} around the body, since it is multiline (per style guide.)


WebCore/inspector/front-end/TextPrompt.js:235
 +                          if (commonPrefix[j] != completion[j]) {
!==

WebCore/inspector/front-end/TextPrompt.js:236
 +                              commonPrefix = commonPrefix.substr(0,j);
Add a space after ",".

Otherwise looks great! Thanks for the screencast.

[Ilya Tikhonovsky]

Created attachment 55384 [details]
[patch] second iteration.

coding style changes.

[WebKit Commit Bot]

Comment on attachment 55384 [details]
[patch] second iteration.

Clearing flags on attachment: 55384

Committed r59025: <http://trac.webkit.org/changeset/59025>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.