Summary: | Web Inspector: Autocompletion in console is not usable because it is not add to the entered text the common prefix of suggestions. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ilya Tikhonovsky <loislo> | ||||||||
Component: | Web Inspector (Deprecated) | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, pfeldman, timothy, yurys | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Ilya Tikhonovsky
2010-05-07 08:28:15 PDT
Created attachment 55378 [details]
[patch] Initial version.
Created attachment 55379 [details]
screencast
Comment on attachment 55378 [details]
[patch] Initial version.
WebCore/inspector/front-end/TextPrompt.js:234
+ for (var j = wordPrefixLength; j < lastIndex; ++j)
Need {} around the body, since it is multiline (per style guide.)
WebCore/inspector/front-end/TextPrompt.js:248
+ for (var i = 0; i < completions.length; ++i)
Need {} around the body, since it is multiline (per style guide.)
WebCore/inspector/front-end/TextPrompt.js:235
+ if (commonPrefix[j] != completion[j]) {
!==
WebCore/inspector/front-end/TextPrompt.js:236
+ commonPrefix = commonPrefix.substr(0,j);
Add a space after ",".
Otherwise looks great! Thanks for the screencast.
Created attachment 55384 [details]
[patch] second iteration.
coding style changes.
Comment on attachment 55384 [details] [patch] second iteration. Clearing flags on attachment: 55384 Committed r59025: <http://trac.webkit.org/changeset/59025> All reviewed patches have been landed. Closing bug. |