Summary: | [Qt] qwebframe auto test doesn't compile | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Samuel Nevala <samuel.nevala> | ||||
Component: | Tools / Tests | Assignee: | QtWebKit Unassigned <webkit-qt-unassigned> | ||||
Status: | CLOSED FIXED | ||||||
Severity: | Blocker | CC: | commit-queue, hausmann, jesus, kenneth, laszlo.gombos | ||||
Priority: | P1 | Keywords: | Qt | ||||
Version: | 420+ | ||||||
Hardware: | S60 Emulator | ||||||
OS: | S60 3rd edition | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 38721 | ||||||
Attachments: |
|
Description
Samuel Nevala
2010-05-06 22:12:29 PDT
Fix: ------- src/3rdparty/webkit/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp ------- index e3de123..d04a652 100644 @@ -780,7 +780,7 @@ void tst_QWebFrame::getSetStaticProperty() QCOMPARE(vm.size(), 3); QCOMPARE(vm.value("a").toInt(), 123); QCOMPARE(vm.value("b").toString(), QLatin1String("foo")); - QCOMPARE(vm.value("c").value<QObject*>(), m_myObject); + QCOMPARE(vm.value("c").value<QObject*>(), static_cast<QObject*>(m_myObject)); } QCOMPARE(evalJS("myObject.variantMapProperty.a === 123"), sTrue); QCOMPARE(evalJS("myObject.variantMapProperty.b === 'foo'"), sTrue); Created attachment 56475 [details]
proper patch
This is known WINSCW issue that shows up a lot when doing calls where templated arguments
have same base class and parameters are passed with derived class types.
Comment on attachment 56475 [details] proper patch Clearing flags on attachment: 56475 Committed r59838: <http://trac.webkit.org/changeset/59838> All reviewed patches have been landed. Closing bug. |