Bug 38699

Summary:

Improve code generator scripts to support converting ScriptString

Product:

WebKit

Reporter:

Jian Li <jianli>

Component:

WebCore JavaScript

Assignee:

Jian Li <jianli>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, eric, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Proposed Patch	abarth: review+, jianli: commit-queue-

Jian Li

Reported 2010-05-06 15:43:08 PDT

Improve code generator scripts to support converting ScriptString This is needed in order to avoid custom bindings code for FileReader interface.

Attachments
Proposed Patch (12.17 KB, patch) 2010-05-06 16:43 PDT, Jian Li	abarth: review+ jianli: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Jian Li

Comment 1 2010-05-06 16:43:41 PDT

Created attachment 55319 [details] Proposed Patch

WebKit Review Bot

Comment 2 2010-05-06 16:49:03 PDT

Attachment 55319 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:473: Extra space before ( in function call [whitespace/parens] [4] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:475: Extra space before ( in function call [whitespace/parens] [4] WebCore/bindings/scripts/test/JS/JSTestObj.cpp:63: Missing spaces around | [whitespace/operators] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.h:173: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 4 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.

Adam Barth

Comment 3 2010-05-06 16:53:10 PDT

Comment on attachment 55319 [details] Proposed Patch Thanks!

Jian Li

Comment 4 2010-05-06 17:02:02 PDT

Committed as http://trac.webkit.org/changeset/58921.

Note You need to log in before you can comment on or make changes to this bug.