Bug 38686

Summary:

[CHROMIUM] Chromium port should support image interpolation quality

Product:

WebKit

Reporter:

Stephen White <senorblanco>

Component:

Platform

Assignee:

Stephen White <senorblanco>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, commit-queue, eric, fishd, jamesr, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Windows 7

Attachments:

Description	Flags
Patch	none
New Win+Linux baselines	none

Description Stephen White 2010-05-06 13:39:40 PDT

The Chromium port does not currently support the GraphicsContext::setInterpolationQuality() call.  This should be implemented, to allow performance scaling depending on page content.

Comment 1 Stephen White 2010-05-28 08:42:14 PDT

Created attachment 57332 [details]
Patch

Comment 2 Darin Fisher (:fishd, Google) 2010-05-28 10:00:14 PDT

Comment on attachment 57332 [details]
Patch

WebCore/platform/graphics/skia/PlatformContextSkia.cpp:127
 +      , m_interpolationQuality(WebCore::InterpolationHigh)
it seems like all of this code should be in the WebCore namespace.
oh well, cleanup for another time...

Comment 3 WebKit Commit Bot 2010-05-28 23:28:05 PDT

Comment on attachment 57332 [details]
Patch

Clearing flags on attachment: 57332

Committed r60391: <http://trac.webkit.org/changeset/60391>

Comment 4 WebKit Commit Bot 2010-05-28 23:28:16 PDT

All reviewed patches have been landed.  Closing bug.

Comment 5 WebKit Review Bot 2010-05-28 23:50:33 PDT

http://trac.webkit.org/changeset/60391 might have broken Qt Linux ARMv7 Release
The following changes are on the blame list:
http://trac.webkit.org/changeset/60392
http://trac.webkit.org/changeset/60391

Comment 6 Stephen White 2010-05-31 08:20:35 PDT

Reopening to add new test baselines.

Comment 7 Stephen White 2010-05-31 08:28:23 PDT

Created attachment 57471 [details]
New Win+Linux baselines

Comment 8 Dimitri Glazkov (Google) 2010-05-31 08:44:54 PDT

Comment on attachment 57471 [details]
New Win+Linux baselines

ok.

Comment 9 WebKit Commit Bot 2010-05-31 15:40:50 PDT

Comment on attachment 57471 [details]
New Win+Linux baselines

Clearing flags on attachment: 57471

Committed r60453: <http://trac.webkit.org/changeset/60453>

Comment 10 WebKit Commit Bot 2010-05-31 15:40:58 PDT

All reviewed patches have been landed.  Closing bug.

Comment 11 James Robinson 2010-06-02 17:06:46 PDT

This broke scaled background image tiling.  See http://code.google.com/p/chromium/issues/detail?id=45694.  The change at line 187 of http://trac.webkit.org/changeset/60391/trunk/WebCore/platform/graphics/skia/ImageSkia.cpp looks to be at fault, I'm not sure why that was changed from && to || but changing it back seems to fix the bug.