Bug 38685 – [Qt] tst_QWebPage::inputMethods failing on Maemo5

• Component: WebKit Qt
• Status: CLOSED FIXED

[Diego Gonzalez]

Test failing in Maemo 5 with Qt4.6

FAIL!  : tst_QWebPage::inputMethods(QWebView) '!viewEventSpy.contains(QEvent::RequestSoftwareInputPanel)' returned FALSE. ()
   Loc: [/home/diegohcg/webkit/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp(1370)] 
FAIL!  : tst_QWebPage::inputMethods(QGraphicsWebView) '!viewEventSpy.contains(QEvent::RequestSoftwareInputPanel)' returned FALSE. ()
   Loc: [/home/diegohcg/webkit/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp(1370)]

[Diego Gonzalez]

The test checks if there is no RequestSoftwareInputPanel event in the EventSpy, when the input form receives a mouse click. 

QVERIFY(!viewEventSpy.contains(QEvent::RequestSoftwareInputPanel));

As the RequestSoftwareInputPanel should invoke a panel like a virtual keyboard, in Maemo it seems be called as it is a mobile platform. So, for the Maemo's case, the behavior of this the should be changed the the opposite. 

QVERIFY(viewEventSpy.contains(QEvent::RequestSoftwareInputPanel));

Maybe this test should also fail in another mobile platform like s60, but I didn't test it.

[Diego Gonzalez]

Created attachment 55422 [details]
Patch

[Kenneth Rohde Christiansen]

Laszlo, can you verify?

[Kenneth Rohde Christiansen]

Comment on attachment 55422 [details]
Patch

WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:1368
 +  #ifndef Q_WS_MAEMO_5
It would really be good with a comment here why there are different results, r- because of that. That should ALSO be in the ChangeLog.

[Diego Gonzalez]

Created attachment 55423 [details]
Patch

Added comments

[Simon Hausmann]

Comment on attachment 55423 [details]
Patch

So this part of the test checks that the SIP is triggered not on the first mouse click but on the _second_, corresponding to style->styleHint(...::RequestSoftwareInputPanel) != RSIP_OnMouseClick.

See QWebPagePrivate::handleSoftwareInputPanel

So the auto-test should probably adjust its expected result - either RSIP on first or second click - depending on the return value of the styleHint() function on the current style.

Then the auto-test could be written without platform #ifdefs :)

[Diego Gonzalez]

(In reply to comment #6)
> (From update of attachment 55423 [details])
> So this part of the test checks that the SIP is triggered not on the first mouse click but on the _second_, corresponding to style->styleHint(...::RequestSoftwareInputPanel) != RSIP_OnMouseClick.
> 
> See QWebPagePrivate::handleSoftwareInputPanel
> 
> So the auto-test should probably adjust its expected result - either RSIP on first or second click - depending on the return value of the styleHint() function on the current style.
> 
> Then the auto-test could be written without platform #ifdefs :)

Yeah sure, it's make more sense. Thanks :)

[Diego Gonzalez]

Created attachment 55735 [details]
Patch

Check if SIP is triggered via styleHint

[Kenneth Rohde Christiansen]

Comment on attachment 55735 [details]
Patch


WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:1371
 +      int  inputPanel= 0;
wrong coding style

WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:1383
 +          QVERIFY(!viewEventSpy.contains(QEvent::RequestSoftwareInputPanel));
As said earlier, can be please add a comment here explaining the difference

[Diego Gonzalez]

Created attachment 55739 [details]
Patch

added more comments

[Kenneth Rohde Christiansen]

Comment on attachment 55739 [details]
Patch

WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:1384
 +      // part of the test can verified as the checks bellow.
below

WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:1381
 +      // because there is no SIP (Software Input Panel) triggered. In case of mobile
In the case of a mobile platform, AN input panel

WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:1382
 +      // platforms a input panel, e.g. virtual keyboard, is normally invoked and the
usually might be better than normally

WebKit/qt/ChangeLog:10
+         Check if the SIP (Software Input Panel) is triggered,
+         which normally happens on mobile platforms, when a user input form receives
+         a mouse click.

Strange word wrap

[Diego Gonzalez]

Created attachment 55756 [details]
Patch OK

Adjust comments in the already r+ patch

[Diego Gonzalez]

Landed manually at r59380.

[Simon Hausmann]

<cherry-pick-for-backport: r59380>

[Simon Hausmann]

Revision r59380 cherry-picked into qtwebkit-2.0 with commit f5e95b4fdb7411ca7fbdb7ac1552acd47741e100