Bug 38682

Summary:

further fixes towards REGRESSION (r57292): 1% PLT regression from visited link information leak fix

Product:

WebKit

Reporter:

Maciej Stachowiak <mjs>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, eric, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	darin: review+

Maciej Stachowiak

Reported 2010-05-06 13:23:17 PDT

further fixes towards REGRESSION (r57292): 1% PLT regression from visited link information leak fix

Attachments
Patch (73.98 KB, patch) 2010-05-06 14:01 PDT, Maciej Stachowiak	darin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Maciej Stachowiak

Comment 1 2010-05-06 14:01:19 PDT

Created attachment 55295 [details] Patch

Darin Adler

Comment 2 2010-05-06 15:25:32 PDT

Comment on attachment 55295 [details] Patch > + void setStyleChange(StyleChangeType changeType); No need for an argument name here. I read the rest carefully and this looks great. r=me

Maciej Stachowiak

Comment 3 2010-05-06 15:41:40 PDT

Committed r58914: <http://trac.webkit.org/changeset/58914>

WebKit Review Bot

Comment 4 2010-05-06 18:03:22 PDT

http://trac.webkit.org/changeset/58914 might have broken Qt Windows 32-bit Release The following changes are on the blame list: http://trac.webkit.org/changeset/58912 http://trac.webkit.org/changeset/58913 http://trac.webkit.org/changeset/58914 http://trac.webkit.org/changeset/58915 http://trac.webkit.org/changeset/58916 http://trac.webkit.org/changeset/58917 http://trac.webkit.org/changeset/58918

Eric Seidel (no email)

Comment 5 2010-05-06 19:53:04 PDT

I believe either this patch (http://trac.webkit.org/changeset/58914) or http://trac.webkit.org/changeset/58917 caused this failure: http://build.webkit.org/results/Tiger%20Intel%20Release/r58918%20(11721)/webarchive/test-link-rel-icon-pretty-diff.html

Note You need to log in before you can comment on or make changes to this bug.