Bug 38655

Summary:

[Qt] REGRESSION(r58497) tst_QGraphicsWebView::crashOnViewlessWebPages() is failing

Product:

WebKit

Reporter:

Jesus Sanchez-Palencia <jesus>

Component:

Tools / Tests

Assignee:

Kenneth Rohde Christiansen <kenneth>

Status:

CLOSED FIXED

Severity:

Normal

CC:

benjamin, commit-queue, eric, hausmann, kenneth, kling, tonikitoo

Priority:

Keywords:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

38654

Attachments:

Description	Flags
Patch	none
Patch 2 (fixes typo)	laszlo.gombos: review+

Jesus Sanchez-Palencia

Reported 2010-05-06 10:19:05 PDT

Using Qt 4.7 HEAD 32ecf8e8ad326ea13ec9a430c99ce540e8b4efac and WebKit r58755, this test failed on Linux and crashed on Mac OS X (Snow Leopard). With Qt 4.6 and the same WebKit revision and does not fail on Maemo 5.

Attachments
Patch (3.25 KB, patch) 2010-05-11 10:42 PDT, Kenneth Rohde Christiansen	no flags	Details Formatted Diff Diff
Patch 2 (fixes typo) (3.25 KB, patch) 2010-05-11 11:52 PDT, Kenneth Rohde Christiansen	laszlo.gombos: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Antonio Gomes

Comment 1 2010-05-09 20:41:26 PDT

reproducible on both release and debud builds. I can have a look

Antonio Gomes

Comment 2 2010-05-10 21:48:50 PDT

this autotest has a failing history: * r56529 - NO BUG - broke it * r57323 - bug 37317 - fixed it * r58497 - bug 38179 - broke it again

Kenneth Rohde Christiansen

Comment 3 2010-05-11 10:34:51 PDT

The bug is causes by the fact that a resize of an empty page causes a layout, thus deleting the qgraphicswebview before setHtml is called, which then deletes it again, causing a double free. Patch coming.

Kenneth Rohde Christiansen

Comment 4 2010-05-11 10:42:39 PDT

Created attachment 55719 [details] Patch

Kenneth Rohde Christiansen

Comment 5 2010-05-11 11:52:19 PDT

Created attachment 55730 [details] Patch 2 (fixes typo)

Laszlo Gombos

Comment 6 2010-05-11 11:53:16 PDT

Comment on attachment 55730 [details] Patch 2 (fixes typo) Looks good to me, r+.

WebKit Commit Bot

Comment 7 2010-05-12 19:49:27 PDT

Comment on attachment 55730 [details] Patch 2 (fixes typo) Rejecting patch 55730 from commit-queue. Unexpected failure when landing patch! Please file a bug against webkit-patch. Failed to run "['../WebKit/WebKitTools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', 'land-attachment', '--force-clean', '--build', '--non-interactive', '--ignore-builders', '--build-style=both', '--quiet', 55730, '--test', '--parent-command=commit-queue', '--no-update']" exit_code: 1 Last 500 characters of output: id=55730&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=38655&ctype=xml Processing 1 patch from 1 bug. Cleaning working directory Processing patch 55730 from bug 38655. NOBODY (OOPS!) found in /Users/eseidel/Projects/CommitQueue/WebKit/qt/ChangeLog does not appear to be a valid reviewer according to committers.py. ERROR: /Users/eseidel/Projects/CommitQueue/WebKit/qt/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Eric Seidel (no email)

Comment 8 2010-05-12 20:10:24 PDT

This false rejection is caused by bug 38998. This won't work in the commit-queue until that's fixed, sorry. :(

Antonio Gomes

Comment 9 2010-05-13 11:59:39 PDT

Committed r59378: <http://trac.webkit.org/changeset/59378>

Simon Hausmann

Comment 10 2010-05-14 01:10:26 PDT

Revision r59378 cherry-picked into qtwebkit-2.0 with commit 3e4eb12fb842fa1709551e05c52fc695014a21fa

Note You need to log in before you can comment on or make changes to this bug.