Bug 38645

Summary:

[Qt] Failed at http://philip.html5.org/tests/canvas/suite/tests/2d.path.arcTo.ensuresubpath.1.html

Product:

WebKit

Reporter:

qi <qi.2.zhang>

Component:

New Bugs

Assignee:

qi <qi.2.zhang>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, cshu, darin, kenneth, kling, laszlo.gombos, ossy

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
patch	none
patch2	none
patch3	none

Reported 2010-05-06 07:34:49 PDT

Based on HTML5: The arcTo(x1, y1, x2, y2, radius) method must first ensure there is a subpathp240 for (x1, y1). Then, the behavior depends on the arguments and the last point in the subpath, as described below.

Attachments
patch (1.29 KB, patch) 2010-05-06 07:43 PDT, qi	no flags	Details Formatted Diff Diff
patch2 (2.97 KB, patch) 2010-06-03 07:45 PDT, qi	no flags	Details Formatted Diff Diff
patch3 (2.98 KB, patch) 2010-06-03 12:05 PDT, qi	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Comment 1 2010-05-06 07:43:09 PDT

Created attachment 55236 [details] patch put a patch

Darin Adler

Comment 2 2010-05-06 09:40:45 PDT

In the WebKit project we require test cases for bugs being fixed. Can we somehow import this test suite?

Csaba Osztrogonác

Comment 3 2010-05-31 10:32:00 PDT

(In reply to comment #2) > In the WebKit project we require test cases for bugs being fixed. Can we somehow import this test suite? Philip's test cases was landed: https://bugs.webkit.org/show_bug.cgi?id=20553 , so we can check this bug now. I tested this patch, it fixes canvas/philip/tests/2d.path.arcTo.ensuresubpath.1.html, but unfortunately brake an other test case: canvas/philip/tests/2d.path.arcTo.ensuresubpath.2.html -Passed +Failed assertion: got pixel [255,0,0,255] at (50,25), expected [0,255,0,255]

Comment 4 2010-06-01 05:43:44 PDT

I will check this bug with the philip test case and make a new patch soon.

Comment 5 2010-06-03 07:45:09 PDT

Created attachment 57766 [details] patch2 Create a new patch to: 1> enable canvas/philip/tests/2d.path.arcTo.ensuresubpath.1.html 2> changed the code to add moveTo when there is no subpath

Comment 6 2010-06-03 12:05:37 PDT

Created attachment 57797 [details] patch3 Minor change on comments.

Laszlo Gombos

Comment 7 2010-06-03 12:15:50 PDT

Comment on attachment 57797 [details] patch3 lgtm, r+.

WebKit Commit Bot

Comment 8 2010-06-04 01:32:13 PDT

Comment on attachment 57797 [details] patch3 Clearing flags on attachment: 57797 Committed r60664: <http://trac.webkit.org/changeset/60664>

WebKit Commit Bot

Comment 9 2010-06-04 01:32:21 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.