Bug 38632

Summary: [DRT/Chromium] ImageDiff should depend on WebKit
Product: WebKit Reporter: jochen
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, dglazkov, eric, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch none

jochen
Reported 2010-05-06 01:39:53 PDT
[DRT/Chromium] ImageDiff should depend on WebKit
Attachments
Patch (1.36 KB, patch)
2010-05-06 01:46 PDT, jochen 		no flags
DetailsFormatted DiffDiff
Patch (1.37 KB, patch)
2010-05-06 01:48 PDT, jochen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
jochen
Comment 1 2010-05-06 01:46:45 PDT
Created attachment 55216 [details] Patch
jochen
Comment 2 2010-05-06 01:48:06 PDT
Created attachment 55217 [details] Patch
jochen
Comment 3 2010-05-06 01:55:42 PDT
If you compile ImageDiff from within chromium with shared libraries, you run into undefined symbols: CurrentTime and ChromiumBridge::callOnMainThread. That's because these symbols are declared in WTF (and used) but defined in WebKit/chromium/src/ChromiumBridge.cpp
Kent Tamura
Comment 4 2010-05-06 02:11:43 PDT
Comment on attachment 55217 [details] Patch This change looks ok.
Dimitri Glazkov (Google)
Comment 5 2010-05-06 08:31:48 PDT
Comment on attachment 55217 [details] Patch ok.
WebKit Commit Bot
Comment 6 2010-05-06 09:46:50 PDT
Comment on attachment 55217 [details] Patch Clearing flags on attachment: 55217 Committed r58889: <http://trac.webkit.org/changeset/58889>
WebKit Commit Bot
Comment 7 2010-05-06 09:46:56 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 8 2010-05-06 10:26:23 PDT
http://trac.webkit.org/changeset/58889 might have broken GTK Linux 64-bit Release
Note You need to log in before you can comment on or make changes to this bug.