Bug 38631 – Chromium Dev Tools: Large toolbar icons flash when dev tools is opened in docked mode.

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Pavel Feldman]

Today, inspector has a chance to be rendered before the theme and docked state are set. As a result, large toolbar icons flicker.

[Pavel Feldman]

Created attachment 55214 [details]
[PATCH] Proposed change.

[Timothy Hatcher]

Comment on attachment 55214 [details]
[PATCH] Proposed change.

WebKit/chromium/src/js/DevTools.js:195
 +      var paramsIndex = window.location.href.indexOf("?");
Use window.location.search, and it will be just the query string part (plus the prefix "?".)

WebKit/chromium/src/js/DevTools.js:200
 +              var pair = params[i].split("=");
Do you need to worry about URL encoding? If so you should call decodeURIComponent.

WebKit/chromium/src/js/DevTools.js:202
 +          }
I like extra lines after these.

WebKit/chromium/src/js/DevTools.js:207
 +  }
Ditto.

Use window.location.search, otherwise r+.

[Pavel Feldman]

Created attachment 55242 [details]
[PATCH] Review comments addressed.

Thanks for the hint!

I don't care about escaping - I am passing booleans and rgb values, all latin, works for me locally.

[Timothy Hatcher]

Comment on attachment 55242 [details]
[PATCH] Review comments addressed.

> -        this.drawer.resize();
> +        if (this.drawer)
> +            this.drawer.resize();

Why this change?

[Pavel Feldman]

(In reply to comment #4)
> (From update of attachment 55242 [details])
> > -        this.drawer.resize();
> > +        if (this.drawer)
> > +            this.drawer.resize();
> 
> Why this change?

Before Joe's change, setAttached could be called early (before drawer was created). And we actually need it to be called early.

[Pavel Feldman]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/inspector/front-end/ResourceView.js
	M	WebCore/inspector/front-end/inspector.js
	M	WebKit/chromium/ChangeLog
	M	WebKit/chromium/src/js/DevTools.js
Committed r58890

[WebKit Review Bot]

http://trac.webkit.org/changeset/58890 might have broken Qt Linux Release

[Timothy Hatcher]

No.