Bug 38628

Summary: svn-apply: should recognize "copy from" with similarity index 100%
Product: WebKit Reporter: Chris Jerdonek <cjerdonek>
Component: Tools / TestsAssignee: Chris Jerdonek <cjerdonek>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cjerdonek, dbates, eric, kenneth
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 32834    
Attachments:
Description Flags
Proposed patch
cjerdonek: commit-queue-
Proposed patch 2
cjerdonek: commit-queue-
Proposed patch 3 dbates: review+, cjerdonek: commit-queue-

Chris Jerdonek
Reported 2010-05-05 22:36:42 PDT
For bug 32834, let's start out by adding support for "copy from" with similarity index 100%. Supporting "rename" (i.e. file moves) or copies with similarity index < 100% will require slightly more work. The reason is that with those, a single git diff will correspond to more than one operation. For example, a rename with s.i. 100% corresponds to a copy followed by a delete, a copy with s.i. < 100% corresponds to a copy followed by a modification, and a rename with s.i. < 100% corresponds to a copy followed by a delete followed by a modification. We can achieve the latter by having VCSUtil.pm's parseDiff() return an array of diff hashes rather than a single one.
Attachments
Proposed patch (4.73 KB, patch)
2010-05-06 00:30 PDT, Chris Jerdonek 		cjerdonek: commit-queue-
DetailsFormatted DiffDiff
Proposed patch 2 (5.01 KB, patch)
2010-05-06 00:33 PDT, Chris Jerdonek 		cjerdonek: commit-queue-
DetailsFormatted DiffDiff
Proposed patch 3 (5.48 KB, patch)
2010-05-06 08:11 PDT, Chris Jerdonek 		dbates: review+
cjerdonek: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Jerdonek
Comment 1 2010-05-06 00:30:32 PDT
Created attachment 55207 [details] Proposed patch
Chris Jerdonek
Comment 2 2010-05-06 00:33:08 PDT
Created attachment 55208 [details] Proposed patch 2 Updated ChangeLog.
Chris Jerdonek
Comment 3 2010-05-06 08:11:51 PDT
Created attachment 55240 [details] Proposed patch 3 Updated the parseGitDiffHeader() code comment; fixed || expression.
Daniel Bates
Comment 4 2010-05-06 19:51:15 PDT
Comment on attachment 55240 [details] Proposed patch 3 Can we just add a unit test for when similiarity-index is not equal to 100%? Looks good to me.
Chris Jerdonek
Comment 5 2010-05-06 20:03:36 PDT
(In reply to comment #4) > (From update of attachment 55240 [details]) > Can we just add a unit test for when similiarity-index is not equal to 100%? > > Looks good to me. Of course, will do. Thanks a lot for the review, Daniel.
Chris Jerdonek
Comment 6 2010-05-06 20:15:34 PDT
Committed: http://trac.webkit.org/changeset/58932
Note You need to log in before you can comment on or make changes to this bug.