Bug 38605

Summary: [chromium] WebKit API additions to support appcache in workers.
Product: WebKit Reporter: Michael Nordman <michaeln>
Component: WebKit APIAssignee: Michael Nordman <michaeln>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dglazkov, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
add param
none
take2
none
take3 none

Michael Nordman
Reported 2010-05-05 13:38:15 PDT
This is a subtask of http://code.google.com/p/chromium/issues/detail?id=39368 Need to add an extra parameter to the WebSharedWorker::startWorkerContext() method to indicate which appcache (by long long appcacheId) the shared worker resource was loaded from, and provide that value when webcore/webkit calls out to chrome via this interface.
Attachments
add param (8.87 KB, patch)
2010-05-05 14:48 PDT, Michael Nordman 		no flags
DetailsFormatted DiffDiff
take2 (8.77 KB, patch)
2010-05-05 19:34 PDT, Michael Nordman 		no flags
DetailsFormatted DiffDiff
take3 (8.98 KB, patch)
2010-05-06 10:14 PDT, Michael Nordman 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Michael Nordman
Comment 1 2010-05-05 14:48:37 PDT
Created attachment 55157 [details] add param
Michael Nordman
Comment 2 2010-05-05 15:26:13 PDT
Fyi: This interface is both... * used by webkit/webcore to call out to chrome (in the renderer process) * used by chrome to call into webkit/webcore (in the worker process) ... so altering a method in this interface makes for multi-sided patch sequencing.
Michael Nordman
Comment 3 2010-05-05 19:34:24 PDT
Created attachment 55194 [details] take2 A new patch that avoids making a copy of the ResourceResponse.
WebKit Review Bot
Comment 4 2010-05-05 21:02:18 PDT
Attachment 55194 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/2194008
Michael Nordman
Comment 5 2010-05-05 21:14:21 PDT
Great, forgot to define the method in the class definition. Moving edits from this client to that client is such an error prone time sync hole.
Michael Nordman
Comment 6 2010-05-06 10:14:46 PDT
Created attachment 55254 [details] take3
Dmitry Titov
Comment 7 2010-05-06 11:11:06 PDT
Comment on attachment 55254 [details] take3 r=me
WebKit Commit Bot
Comment 8 2010-05-08 05:39:36 PDT
Comment on attachment 55254 [details] take3 Clearing flags on attachment: 55254 Committed r59022: <http://trac.webkit.org/changeset/59022>
WebKit Commit Bot
Comment 9 2010-05-08 05:39:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.