Bug 38605

Summary: [chromium] WebKit API additions to support appcache in workers.
Product: WebKit Reporter: Michael Nordman <michaeln>
Component: WebKit APIAssignee: Michael Nordman <michaeln>
Severity: Normal CC: commit-queue, dglazkov, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Description Flags
add param
take3 none

Description Michael Nordman 2010-05-05 13:38:15 PDT
This is a subtask of http://code.google.com/p/chromium/issues/detail?id=39368

Need to add an extra parameter to the WebSharedWorker::startWorkerContext() method to indicate which appcache (by long long appcacheId) the shared worker resource was loaded from, and provide that value when webcore/webkit calls out to chrome via this interface.
Comment 1 Michael Nordman 2010-05-05 14:48:37 PDT
Created attachment 55157 [details]
add param
Comment 2 Michael Nordman 2010-05-05 15:26:13 PDT
Fyi: This interface is both...
* used by webkit/webcore to call out to chrome (in the renderer process)
* used by chrome to call into webkit/webcore (in the worker process)
... so altering a method in this interface makes for multi-sided patch sequencing.
Comment 3 Michael Nordman 2010-05-05 19:34:24 PDT
Created attachment 55194 [details]

A new patch that avoids making a copy of the ResourceResponse.
Comment 4 WebKit Review Bot 2010-05-05 21:02:18 PDT
Attachment 55194 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/2194008
Comment 5 Michael Nordman 2010-05-05 21:14:21 PDT
Great, forgot to define the method in the class definition. Moving edits from this client to that client is such an error prone time sync hole.
Comment 6 Michael Nordman 2010-05-06 10:14:46 PDT
Created attachment 55254 [details]
Comment 7 Dmitry Titov 2010-05-06 11:11:06 PDT
Comment on attachment 55254 [details]

Comment 8 WebKit Commit Bot 2010-05-08 05:39:36 PDT
Comment on attachment 55254 [details]

Clearing flags on attachment: 55254

Committed r59022: <http://trac.webkit.org/changeset/59022>
Comment 9 WebKit Commit Bot 2010-05-08 05:39:41 PDT
All reviewed patches have been landed.  Closing bug.