Summary: | workers-gc2 crashing on Qt | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gavin Barraclough <barraclough> | ||||
Component: | Web Template Framework | Assignee: | Gavin Barraclough <barraclough> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | darin, ossy | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Gavin Barraclough
2010-05-05 13:30:22 PDT
Created attachment 55150 [details]
The patch
Comment on attachment 55150 [details] The patch > + on AtomicStrings â it implicitly assumes that all AtomicStrings have already You should stick to ASCII for ChangeLog. > + void setIsAtomic(bool isIdentifier) > + { > + ASSERT(!isStatic()); > + if (isIdentifier) > + m_refCountAndFlags |= s_refCountFlagIsAtomic; > + else > + m_refCountAndFlags &= s_refCountFlagIsAtomic; > + } Maybe a set/clear pair of functions instead of one that takes a bool would be better. (In reply to comment #2) > Maybe a set/clear pair of functions instead of one that takes a bool would be > better. Just to be clear, I’m not asking you to change this right away, just kind of “musing” about it. (In reply to comment #3) > Just to be clear, I’m not asking you to change this right away, just kind of > “musing” about it. I agree - I did it this way for now to match the setIsIdentifier method. I may switch to set/clear methods for both as a separate patch. |