Summary: | [Qt] QtTestBrowser does not have a "Load" button ; therefore, unable to load pages on touch only symbian devices (portrait mode). | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexandra Santos <alexandra.1.santos> | ||||
Component: | New Bugs | Assignee: | QtWebKit Unassigned <webkit-qt-unassigned> | ||||
Status: | CLOSED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, hausmann, jesus, kenneth, tonikitoo | ||||
Priority: | P3 | Keywords: | Qt, QtTriaged | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | S60 Hardware | ||||||
OS: | S60 3rd edition | ||||||
Attachments: |
|
Description
Alexandra Santos
2010-05-05 11:43:49 PDT
Good point! Blocking the 2.0 release as this is simple to solve and quite useful to have. Shouldn't enter from the virtual keyboard close the keyboard and start the load? What does the iphone and the ipad do? Hmm, on my N8 I'm using the "Enter" key (the little arrow) on the virtual keyboard to initiate the load. I'm moving this issue from the release blocker to the should-include-if-patch-is-available tracker. It would be nice to fix QtTestBrowser (the new name :-), but it's not critical to the release I'd say. Created attachment 59658 [details]
patch
Simple patch that makes the reload button act as a load button as well.
Solves the problem and we don't need to add another button. :)
Comment on attachment 59658 [details] patch Clearing flags on attachment: 59658 Committed r61926: <http://trac.webkit.org/changeset/61926> All reviewed patches have been landed. Closing bug. Revision r61926 cherry-picked into qtwebkit-2.0 with commit 38d650efc92427cd6452f6685d3c40d22428cdb7 (In reply to comment #7) > Revision r61926 cherry-picked into qtwebkit-2.0 with commit 38d650efc92427cd6452f6685d3c40d22428cdb7 Nice! But I had to upload a follow-up patch because the behavior was wrong. It wasn't loading a new web page if the url in the line edit had been changed. Simon, could you please cherry-pick this revision as well? http://trac.webkit.org/changeset/62009 Changing back from CLOSED to RESOLVED so we don't forget it... Revision r61926 cherry-picked into qtwebkit-2.0 with commit 38d650efc92427cd6452f6685d3c40d22428cdb7 <cherry-pick-for-backport: r62009> Revision r62009 cherry-picked into qtwebkit-2.0 with commit 0eee8df53d1873669a9dda8f9c0340543258a316 |