Bug 38597

Summary: [Qt] QtTestBrowser does not have a "Load" button ; therefore, unable to load pages on touch only symbian devices (portrait mode).
Product: WebKit Reporter: Alexandra Santos <alexandra.1.santos>
Component: New BugsAssignee: QtWebKit Unassigned <webkit-qt-unassigned>
Status: CLOSED FIXED    
Severity: Normal CC: commit-queue, hausmann, jesus, kenneth, tonikitoo
Priority: P3 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: S60 Hardware   
OS: S60 3rd edition   
Attachments:
Description Flags
patch none

Description Alexandra Santos 2010-05-05 11:43:49 PDT
Since QtLauncher does not have a "load" button, on touch only symbian devices like N8, it is not possible to load pages.

Steps to reproduce:

1.- Install qt.sis (4.6.2), qtwebkit.sis and qtlauncher on the device.
2.- Launch qtlauncher
3.- Enter a url address and try to load the page.

Actual Results:

It is not possible to load pages; there is no "load" or "enter" button.

Expected results:

qtlauncher would have a "Load" button to be pressed in order to load a page.
Comment 1 Jesus Sanchez-Palencia 2010-05-12 08:15:53 PDT
Good point! Blocking the 2.0 release as this is simple to solve and quite useful to have.
Comment 2 Kenneth Rohde Christiansen 2010-05-12 08:29:57 PDT
Shouldn't enter from the virtual keyboard close the keyboard and start the load? What does the iphone and the ipad do?
Comment 3 Simon Hausmann 2010-05-18 13:44:12 PDT
Hmm, on my N8 I'm using the "Enter" key (the little arrow) on the virtual keyboard to initiate the load.


I'm moving this issue from the release blocker to the should-include-if-patch-is-available tracker. It would be nice to fix QtTestBrowser (the new name :-), but it's not critical to the release I'd say.
Comment 4 Jesus Sanchez-Palencia 2010-06-24 08:48:14 PDT
Created attachment 59658 [details]
patch

Simple patch that makes the reload button act as a load button as well.
Solves the problem and we don't need to add another button. :)
Comment 5 WebKit Commit Bot 2010-06-25 17:58:31 PDT
Comment on attachment 59658 [details]
patch

Clearing flags on attachment: 59658

Committed r61926: <http://trac.webkit.org/changeset/61926>
Comment 6 WebKit Commit Bot 2010-06-25 17:58:35 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Simon Hausmann 2010-06-28 03:16:59 PDT
Revision r61926 cherry-picked into qtwebkit-2.0 with commit 38d650efc92427cd6452f6685d3c40d22428cdb7
Comment 8 Jesus Sanchez-Palencia 2010-06-28 08:51:03 PDT
(In reply to comment #7)
> Revision r61926 cherry-picked into qtwebkit-2.0 with commit 38d650efc92427cd6452f6685d3c40d22428cdb7

Nice! But I had to upload a follow-up patch because the behavior was wrong. It wasn't loading a new web page if the url in the line edit had been changed.

Simon, could you please cherry-pick this revision as well?  http://trac.webkit.org/changeset/62009

Changing back from CLOSED to RESOLVED so we don't forget it...
Comment 9 Simon Hausmann 2010-06-30 07:43:18 PDT
Revision r61926 cherry-picked into qtwebkit-2.0 with commit 38d650efc92427cd6452f6685d3c40d22428cdb7
Comment 10 Simon Hausmann 2010-06-30 07:43:46 PDT
<cherry-pick-for-backport: r62009>
Comment 11 Simon Hausmann 2010-07-01 01:32:24 PDT
Revision r62009 cherry-picked into qtwebkit-2.0 with commit 0eee8df53d1873669a9dda8f9c0340543258a316