Bug 38590

Summary: Spatial Navigation: refactor hasOffscreenRect to work with scrollable content
Product: WebKit Reporter: Antonio Gomes <tonikitoo>
Component: AccessibilityAssignee: Antonio Gomes <tonikitoo>
Status: RESOLVED FIXED    
Severity: Normal CC: cshu, laszlo.gombos, yael
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Bug Depends on: 36463    
Bug Blocks: 46905    
Attachments:
Description Flags
patch v1 none

Antonio Gomes
Reported 2010-05-05 09:03:44 PDT
hasOffscreenRect method in SpatialNavigation.cpp currently does not works fine for focusable elements in overflowed content. it needs a refactoring for that.
Attachments
patch v1 (8.28 KB, patch)
2010-05-05 09:07 PDT, Antonio Gomes 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antonio Gomes
Comment 1 2010-05-05 09:07:51 PDT
Created attachment 55130 [details] patch v1 no requestion review as patch depends on patch on bug 36463
Chang Shu
Comment 2 2010-10-06 06:47:08 PDT
This patch needs a re-baseline.
Yael
Comment 3 2010-10-09 14:32:26 PDT
IMO hasOffscreenRect should also take into account scrolling and the direction in which we are scrolling. i.e. if we scroll the frame, due to not finding any element, and then an element becomes visible, that element should be focused, even though it was not visible before we scrolled.
Yael
Comment 4 2010-11-15 13:12:04 PST
hasOffscreenRect() is using absoluteClippedOverflowRect() to get the node's rect. If the node is hidden inside a parent that is scrollable div, absoluteClippedOverflowRect() will return (0,0) for the size of the rect, so I think this function is already doing the right thing.
Antonio Gomes
Comment 5 2011-05-11 09:38:03 PDT
it has been fixed by Yael
Note You need to log in before you can comment on or make changes to this bug.