Bug 38587

Summary: @namespaces rules before @import rules are not invalidated
Product: WebKit Reporter: Daniel Glazman <daniel>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: bdakin, mitz, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
URL: http://www.w3.org/Style/CSS/Test/CSS3/Namespace/20090210/syntax-006.xml
Attachments:
Description Flags
proposed fix #1 none

Daniel Glazman
Reported 2010-05-05 08:11:43 PDT
Created attachment 55126 [details] proposed fix #1 Per CSS 3 Namespaces spec [1], @namespace rules must follow all @charset and @import rules. This is not enforced at this time by CSSParser, and that's one of the last tests from the Namespaces Test Suite WebKit fails [2]. I have written a patch to fix this bug. Please excuse me in advance if it does not strictly follow WebKit coding style rules or misses an important architectural step: this is my very first patch in WebKit... [1] http://www.w3.org/TR/css3-namespace/#syntax [2] http://www.w3.org/Style/CSS/Test/CSS3/Namespace/20090210/syntax-006.xml
Attachments
proposed fix #1 (1.43 KB, patch)
2010-05-05 08:11 PDT, Daniel Glazman
no flags
Simon Fraser (smfr)
Comment 1 2010-05-05 09:13:24 PDT
Comment on attachment 55126 [details] proposed fix #1 Patch is lacking a changelog and testcase, so it's not ready for review, but thanks for the code changes Daniel!
Daniel Glazman
Comment 2 2010-05-05 09:16:07 PDT
Comment on attachment 55126 [details] proposed fix #1 (In reply to comment #1) > (From update of attachment 55126 [details]) > Patch is lacking a changelog and testcase, so it's not ready for review, but > thanks for the code changes Daniel! I think the patch is in fact wrong. I ended up implementing the fix the wrong way because the test in the Test Suite is not really testing the invalidity of a @namespace but only the invalidity of an @import following a @namespace... Revamping, stay tuned.
Alexey Proskuryakov
Comment 3 2010-05-05 13:57:21 PDT
*** This bug has been marked as a duplicate of bug 21472 ***
Note You need to log in before you can comment on or make changes to this bug.