REGRESSION: composited iframe contents no longer visible after r58797

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Simon Fraser (smfr)]

2010-05-04 21:57:31 Simon Fraser:
LayoutTests/compositing/iframes/composited-iframe.html no longer shows the iframe contents on Mac after r58797.

2010-05-04 22:08:37 Simon Fraser:
Patch in src changes.

<rdar://problem/7943945>

[Chris Marrin]

Created attachment 55174 [details]
Patch with pixel test

[Simon Fraser (smfr)]

Comment on attachment 55174 [details]
Patch with pixel test

> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog	(revision 58844)
> +++ WebCore/ChangeLog	(working copy)
> @@ -1,3 +1,18 @@
> [phone]  Chris Marrin  <[e-mail]>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Got composited iframes showing up on Mac again
> +        https://bugs.webkit.org/show_bug.cgi?id=38565

This should have a bit more verbage saying when it regressed, and what you did to fix it.

> Index: LayoutTests/compositing/iframes/composited-iframe-alignment.html
> ===================================================================

> +  <script type="text/javascript" charset="utf-8">
> +    //if (window.layoutTestController) {
> +    //    layoutTestController.dumpAsText();
> +        layoutTestController.waitUntilDone();
> +    //}

Why the commented out lines?

> +    <!-- The parent document should be thrown into compositing mode by the iframe. -->

That's not true on Mac.

r=me with a better changelog and test cleanup.

[Chris Marrin]

Landed in http://trac.webkit.org/changeset/58845