Summary: | [Qt] The image plugin used for decoding images should be configurable | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Benjamin Poulain <benjamin> | ||||
Component: | WebKit API | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED INVALID | ||||||
Severity: | Enhancement | CC: | diegohcg, jturcotte | ||||
Priority: | P2 | Keywords: | Qt, QtTriaged | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Benjamin Poulain
2010-05-04 16:29:53 PDT
Created attachment 89629 [details]
Initial implementation of configurable images loading.
Add initial implementation of configurable images auto loading.
Right now i am just handling png and jpeg and the public api will be changed.
Comment on attachment 89629 [details] Initial implementation of configurable images loading. View in context: https://bugs.webkit.org/attachment.cgi?id=89629&action=review > Source/WebCore/page/Settings.cpp:57 > + for (Frame* frame = page->mainFrame(); frame; frame = frame->tree()->traverseNext()) > + frame->document()->cachedResourceLoader()->setLoadJPEGImage(page->settings()->loadsSiteJPEGImagesIgnoringImageLoadingSetting()); this could be called outside the loop. page->settings()->loadsSiteJPEGImagesIgnoringImageLoadingSetting() > Source/WebCore/page/Settings.cpp:63 > + for (Frame* frame = page->mainFrame(); frame; frame = frame->tree()->traverseNext()) > + frame->document()->cachedResourceLoader()->setLoadPNGImage(page->settings()->loadsSitePNGImagesIgnoringImageLoadingSetting()); Ditto > Source/WebKit/qt/Api/qwebsettings.cpp:630 > +void QWebSettings::enableLoadingImage(const QString &image) & positioned wrong. The goal should be clean, and comments are needed. > Source/WebKit/qt/Api/qwebsettings.cpp:638 > + if (image == QLatin1String("jpeg")) > + d->settings->setLoadsSiteJPEGImagesIgnoringImageLoadingSetting(true); > + else if(image == QLatin1String("png")) > + d->settings->setLoadsSitePNGImagesIgnoringImageLoadingSetting(true); Only caring about these two formats? === Bulk closing of Qt bugs === If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary. If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines. |