|Summary:||Web Inspector: restore main and sidebar scroller positions when switching between panels.|
|Product:||WebKit||Reporter:||Pavel Feldman <pfeldman>|
|Component:||Web Inspector (Deprecated)||Assignee:||Pavel Feldman <pfeldman>|
|Severity:||Normal||CC:||bweinstein, joepeck, keishi, pfeldman, pmuellr, rik, timothy, yurys|
|Version:||528+ (Nightly build)|
Description Pavel Feldman 2010-05-04 08:22:47 PDT
We would still need to store scroll top for views once this lands.
Comment 1 Pavel Feldman 2010-05-04 08:28:32 PDT
Created attachment 55019 [details] [PATCH] Proposed change.
Comment 2 Timothy Hatcher 2010-05-04 08:32:08 PDT
Comment on attachment 55019 [details] [PATCH] Proposed change. WebCore/inspector/front-end/Panel.js:403 + container.__scrollTop = container.scrollTop; I think _storedScrollTop would be clearer than __scrollTop. Nice solution!
Comment 3 Pavel Feldman 2010-05-04 11:50:55 PDT
Landed with comments addressed. Reason I used __ was that it was not a private field, but rather a custom property on a node wrapper (i.e. accessible from other parts of the frontend). I thought we were using __ for that, but I now realize that was the inspected page side where we used __ before. Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/ElementsPanel.js M WebCore/inspector/front-end/Panel.js M WebCore/inspector/front-end/ResourcesPanel.js M WebCore/inspector/front-end/ScriptsPanel.js Committed r58768