Bug 38522

Summary: Web Inspector: restore main and sidebar scroller positions when switching between panels.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: bweinstein, joepeck, keishi, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed change. timothy: review+

Pavel Feldman
Reported 2010-05-04 08:22:47 PDT
We would still need to store scroll top for views once this lands.
Attachments
[PATCH] Proposed change. (4.64 KB, patch)
2010-05-04 08:28 PDT, Pavel Feldman 		timothy: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2010-05-04 08:28:32 PDT
Created attachment 55019 [details] [PATCH] Proposed change.
Timothy Hatcher
Comment 2 2010-05-04 08:32:08 PDT
Comment on attachment 55019 [details] [PATCH] Proposed change. WebCore/inspector/front-end/Panel.js:403 + container.__scrollTop = container.scrollTop; I think _storedScrollTop would be clearer than __scrollTop. Nice solution!
Pavel Feldman
Comment 3 2010-05-04 11:50:55 PDT
Landed with comments addressed. Reason I used __ was that it was not a private field, but rather a custom property on a node wrapper (i.e. accessible from other parts of the frontend). I thought we were using __ for that, but I now realize that was the inspected page side where we used __ before. Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/ElementsPanel.js M WebCore/inspector/front-end/Panel.js M WebCore/inspector/front-end/ResourcesPanel.js M WebCore/inspector/front-end/ScriptsPanel.js Committed r58768
Note You need to log in before you can comment on or make changes to this bug.