Bug 38493

Summary: Get rid of PageClient::isPageVisible and pass visibility directly in setPageIsVisible
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch mitz: review+

Anders Carlsson
Reported 2010-05-03 15:19:09 PDT
Get rid of PageClient::isPageVisible and pass visibility directly in didChangeVisibility
Attachments
Patch (7.18 KB, patch)
2010-05-03 15:27 PDT, Anders Carlsson 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2010-05-03 15:27:19 PDT
Created attachment 54967 [details] Patch
mitz
Comment 2 2010-05-03 15:54:43 PDT
Comment on attachment 54967 [details] Patch r=me only if you rename didChangeVisibility() to setPageIsVisible(). Perhaps m_isVisible should be renamed too.
Anders Carlsson
Comment 3 2010-05-03 16:09:56 PDT
Committed r58714: <http://trac.webkit.org/changeset/58714>
Note You need to log in before you can comment on or make changes to this bug.