Bug 3849

Summary: GW: Add T *QPtrDict::operator()()
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Enhancement    
Priority: P4    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Bug Depends on:    
Bug Blocks: 3250    
Attachments:
Description Flags
self explanitory patch. mjs: review+

Eric Seidel (no email)
Reported 2005-07-04 01:48:32 PDT
Add the very strange T *QPtrDict::operator()() which is used in kdom: T *operator()() { T *ret = (T *)impl.current(); ++impl; return ret; } And is described here: http://doc.trolltech.com/3.3/qptrdictiterator.html#operator()
Attachments
self explanitory patch. (507 bytes, patch)
2005-07-04 01:49 PDT, Eric Seidel (no email)
mjs: review+
Eric Seidel (no email)
Comment 1 2005-07-04 01:49:19 PDT
Created attachment 2787 [details] self explanitory patch.
Maciej Stachowiak
Comment 2 2005-07-04 18:42:06 PDT
Comment on attachment 2787 [details] self explanitory patch. Eric and I discussed this and agreed it is probably a bad idea to iterate over a dictionary this way, instead of using an iterator, so better to fix the caller.
Maciej Stachowiak
Comment 3 2005-07-04 18:47:33 PDT
Comment on attachment 2787 [details] self explanitory patch. ok, this is an iterator method, nonstandard, but not so bad.
Maciej Stachowiak
Comment 4 2005-07-04 18:49:21 PDT
Comment on attachment 2787 [details] self explanitory patch. I'd rather see use of this syntax removed than have support for it added to QDict. But re-request review if it turns out to be too much hassle.
Eric Seidel (no email)
Comment 5 2005-07-04 19:06:46 PDT
Comment on attachment 2787 [details] self explanitory patch. After further discussions on IRC, I think we came to the conclusion that there is a real need for this... even if it is a little "odd".
Note You need to log in before you can comment on or make changes to this bug.